You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "haojin2 (GitHub)" <gi...@apache.org> on 2018/08/23 19:21:22 UTC

[GitHub] [incubator-mxnet] haojin2 opened pull request #12313: Set proper atol for check_with_uniform helper function

## Description ##
Fix for #12312.

## Checklist ##
### Essentials ###
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented: 
- For user-facing API changes, API doc string has been updated. 
- For new C++ functions in header files, their functionalities and arguments are documented. 
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

### Changes ###
- [x] Set proper atol

## Comments ##


[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12313 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy closed pull request #12313: Set proper atol for check_with_uniform helper function

Posted by "sandeep-krishnamurthy (GitHub)" <gi...@apache.org>.
[ pull request closed by sandeep-krishnamurthy ]

[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12313 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-mxnet] haojin2 commented on issue #12313: Set proper atol for check_with_uniform helper function

Posted by "haojin2 (GitHub)" <gi...@apache.org>.
@sandeep-krishnamurthy @nswamy @anirudh2290 Anyone can help with merge?

[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12313 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org