You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2017/01/03 14:49:58 UTC
[jira] [Commented] (SOLR-9909) Nuke one of DefaultSolrThreadFactory
and SolrjNamedThreadFactory
[ https://issues.apache.org/jira/browse/SOLR-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795224#comment-15795224 ]
Christine Poerschke commented on SOLR-9909:
-------------------------------------------
bq. DefaultSolrThreadFactory and SolrjNamedThreadFactory have exactly the same code. Let's remove one of them.
Besides [solr/core's DefaultSolrThreadFactory|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/util/DefaultSolrThreadFactory.java] and [solr/solrj's SolrjNamedThreadFactory|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/SolrjNamedThreadFactory.java] there's also [lucene/core's NamedThreadFactory|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/util/NamedThreadFactory.java] - could we perhaps adapt NamedThreadFactory a little and then remove _both_ DefaultSolrThreadFactory and SolrjNamedThreadFactory classes?
> Nuke one of DefaultSolrThreadFactory and SolrjNamedThreadFactory
> ----------------------------------------------------------------
>
> Key: SOLR-9909
> URL: https://issues.apache.org/jira/browse/SOLR-9909
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Shalin Shekhar Mangar
> Priority: Trivial
> Fix For: master (7.0), 6.4
>
>
> DefaultSolrThreadFactory and SolrjNamedThreadFactory have exactly the same code. Let's remove one of them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org