You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Rogan Carr <ro...@gmail.com> on 2017/07/20 23:11:04 UTC
Overlapping issues
Hi All,
I've taken on REEF-1585, which is updating Org.Apache.REEF.IMRU to .NET
Core compatibility. The issues here are actually all having to do with an
error we throw.
Essentially, I'm converting RemotingException to an allowed exception class.
When I do this, should I also fix the custom throws that we have in the
codebase, or should I leave those unchanged because these are a separate
issue, REEF-1467?
Thanks for your help!
Best,
Rogan
Re: Overlapping issues
Posted by Markus Weimer <ma...@weimo.de>.
On Thu, Jul 20, 2017 at 4:11 PM, Rogan Carr <ro...@gmail.com> wrote:
> When I do this, should I also fix the custom throws that we have in the
> codebase, or should I leave those unchanged because these are a separate
> issue, REEF-1467?
We try to keep changes like that separate in order to have a higher
chance of being able to dissect future breakages.
Markus
Re: Overlapping issues
Posted by Rogan Carr <ro...@gmail.com>.
Thanks Julia! I'm glad I have you here to look over my shoulder!
On Thu, Jul 20, 2017 at 5:17 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com.invalid> wrote:
> Exception type used in IMRU is quite sensitive. This is because some
> exceptions are recoverable in fault tolerant and some are not. For some
> exception types, we handle in one way for generic one we handle in another
> way. So the changes in exception types always need special attention :).
>
> I have left some comments in the PR #1339.
>
> Julia
>
> -----Original Message-----
> From: Rogan Carr [mailto:rogan.carr@gmail.com]
> Sent: Thursday, July 20, 2017 4:11 PM
> To: dev@reef.apache.org
> Subject: Overlapping issues
>
> Hi All,
>
> I've taken on REEF-1585, which is updating Org.Apache.REEF.IMRU to .NET
> Core compatibility. The issues here are actually all having to do with an
> error we throw.
>
> Essentially, I'm converting RemotingException to an allowed exception
> class.
>
> When I do this, should I also fix the custom throws that we have in the
> codebase, or should I leave those unchanged because these are a separate
> issue, REEF-1467?
>
> Thanks for your help!
>
> Best,
> Rogan
>
RE: Overlapping issues
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com.INVALID>.
Exception type used in IMRU is quite sensitive. This is because some exceptions are recoverable in fault tolerant and some are not. For some exception types, we handle in one way for generic one we handle in another way. So the changes in exception types always need special attention :).
I have left some comments in the PR #1339.
Julia
-----Original Message-----
From: Rogan Carr [mailto:rogan.carr@gmail.com]
Sent: Thursday, July 20, 2017 4:11 PM
To: dev@reef.apache.org
Subject: Overlapping issues
Hi All,
I've taken on REEF-1585, which is updating Org.Apache.REEF.IMRU to .NET Core compatibility. The issues here are actually all having to do with an error we throw.
Essentially, I'm converting RemotingException to an allowed exception class.
When I do this, should I also fix the custom throws that we have in the codebase, or should I leave those unchanged because these are a separate issue, REEF-1467?
Thanks for your help!
Best,
Rogan