[GitHub] [arrow] pitrou commented on a diff in pull request #36215: GH-35760: [C++] `ArrowArrayStreamRelease` et all should confirm the struct is released

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #36215:
URL: https://github.com/apache/arrow/pull/36215#discussion_r1238299076


##########
cpp/src/arrow/c/helpers.h:
##########
@@ -18,10 +18,20 @@
 #pragma once
 
 #include <assert.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <string.h>
 
 #include "arrow/c/abi.h"
 
+#define CHECK_OR_DIE(condition, msg)                          \
+  do {                                                        \
+    if (!(condition)) {                                       \
+      fprintf(stderr, "%s:%d:: %s", __FILE__, __LINE__, msg); \
+      std::abort();                                           \

Review Comment:
   This needs to be C code, not C++.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org