[GitHub] [spark] advancedxy commented on a diff in pull request #41257: [SPARK-43657][K8S]: reuse config map for executor when running on k8s-cluster mode

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #41257:
URL: https://github.com/apache/spark/pull/41257#discussion_r1228939681


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala:
##########
@@ -110,7 +110,10 @@ private[spark] class KubernetesClusterSchedulerBackend(
     lifecycleEventHandler.start(this)
     watchEvents.start(applicationId())
     pollEvents.start(applicationId())
-    if (!conf.get(KUBERNETES_EXECUTOR_DISABLE_CONFIGMAP)) {
+    if (!conf.get(KUBERNETES_DRIVER_SUBMIT_CHECK) &&

Review Comment:
   will do.



##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala:
##########
@@ -158,7 +161,8 @@ private[spark] class KubernetesClusterSchedulerBackend(
 
       podAllocator.stop(applicationId())
 
-      if (!conf.get(KUBERNETES_EXECUTOR_DISABLE_CONFIGMAP)) {
+      if (!conf.get(KUBERNETES_DRIVER_SUBMIT_CHECK) &&

Review Comment:
   will do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org