[GitHub] [flink] zentol commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19907:
URL: https://github.com/apache/flink/pull/19907#discussion_r908766389


##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -685,13 +687,27 @@ public CompletableFuture<Acknowledge> submitTask(
                     jobManagerConnection.getClassLoaderHandle();
             PartitionProducerStateChecker partitionStateChecker =
                     jobManagerConnection.getPartitionStateChecker();
+            TernaryBoolean changelogEnabled = TernaryBoolean.FALSE;
+            try {
+                changelogEnabled =
+                        InstantiationUtil.readObjectFromConfig(
+                                taskInformation.getTaskConfiguration(),
+                                "enablechangelog",
+                                getClass().getClassLoader());

Review Comment:
   I would put it into `flink-core` personally; not sure if there is a huge benefit in spreading config options around.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org