You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/10/20 12:22:56 UTC

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/#review103235
-----------------------------------------------------------



3rdparty/libprocess/src/authenticator.cpp (lines 81 - 84)
<https://reviews.apache.org/r/38094/#comment161223>

    Let's stick to non doxygen format style for those.


- Till Toenshoff


On Sept. 30, 2015, 8:21 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38094/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 8:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3232
>     https://issues.apache.org/jira/browse/MESOS-3232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt fb9bd04832779ac43151f2feb3dfbf58cb996434 
>   3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a 
> 
> Diff: https://reviews.apache.org/r/38094/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>