You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/05/16 14:07:31 UTC

[GitHub] [cordova-ios] erisu opened a new pull request #853: breaking: bump xcode w/ fix

erisu opened a new pull request #853:
URL: https://github.com/apache/cordova-ios/pull/853


   ### Motivation, Context & Description
   
   - Upgrade `xcode`
   - Fix prepare & prepare.spec to provide exact targetName
   
   ### Testing
   
   - `npm t`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I upated automated test coverage as appropriate for this change
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #853: breaking: bump xcode w/ fix

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #853:
URL: https://github.com/apache/cordova-ios/pull/853#issuecomment-630518419


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=h1) Report
   > Merging [#853](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/b1d271fed52c3d4b80baa652f0fe9c02167077df&el=desc) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/853/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #853   +/-   ##
   =======================================
     Coverage   74.40%   74.40%           
   =======================================
     Files          13       13           
     Lines        1821     1821           
   =======================================
     Hits         1355     1355           
     Misses        466      466           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/853/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `82.05% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=footer). Last update [b1d271f...b42ad27](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-commenter commented on pull request #853: breaking: bump xcode w/ fix

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #853:
URL: https://github.com/apache/cordova-ios/pull/853#issuecomment-630518419


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=h1) Report
   > Merging [#853](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/b1d271fed52c3d4b80baa652f0fe9c02167077df&el=desc) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/853/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #853   +/-   ##
   =======================================
     Coverage   74.40%   74.40%           
   =======================================
     Files          13       13           
     Lines        1821     1821           
   =======================================
     Hits         1355     1355           
     Misses        466      466           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/853/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `82.05% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=footer). Last update [b1d271f...b42ad27](https://codecov.io/gh/apache/cordova-ios/pull/853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] erisu merged pull request #853: breaking: bump xcode w/ fix

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #853:
URL: https://github.com/apache/cordova-ios/pull/853


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] NiklasMerz commented on a change in pull request #853: breaking: bump xcode w/ fix

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #853:
URL: https://github.com/apache/cordova-ios/pull/853#discussion_r426394728



##########
File path: package.json
##########
@@ -52,7 +52,7 @@
     "semver": "^6.3.0",
     "shelljs": "^0.5.3",
     "unorm": "^1.4.1",
-    "xcode": "^2.0.0",
+    "xcode": "github:apache/cordova-node-xcode#3.0.1",

Review comment:
       xcode 3.0.1 should be ready. So we could use the NPM version here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org