[GitHub] [airflow] uranusjr opened a new issue #16804: Refactor SimpleTaskInstance to prevent future TaskInstance field addition to lost during serialisation

[GitBox <gi...@apache.org>]

uranusjr opened a new issue #16804:
URL: https://github.com/apache/airflow/issues/16804


   Context: #16768
   
   > Right now, if a field is added to `TaskInstace`, `SimpleTaskInstace` and `_execute_task_callbacks` needed to be checked to pass them on. This can be difficult to maintain.
   
   Ideas are very much welcomed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #16804: Refactor SimpleTaskInstance to prevent future TaskInstance field addition to lost during serialisation

[GitBox <gi...@apache.org>]

potiuk commented on issue #16804:
URL: https://github.com/apache/airflow/issues/16804#issuecomment-877859469


   1) Pre-commit check. We do a lot of that already, but if there are some implicit deps, pre-commit check is great as it will simply fail static checks.  This could be done in various ways
   
   2) Another option is write a dedicated unit test simply that would just intstantiate the objects in various various ways and run execute_callbacks ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org