You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Phippard <Ma...@softlanding.com> on 2005/04/05 20:48:16 UTC

[PATCH] - Mistake in 1.2 Release Notes

I assume that this was a mistake.  I believe that svnlook diff 
--no-diff-deleted was already an option.  So presumaly, it is 
--no-diff-added that is the new feature.

I can commit this if you would like, but feel free to just do it yourself.

Thanks


[[[
Correct new command line switch for svnlook diff.

* www/svn_1.2_releasenotes.html
  Flipped references to --no-diff-deleted and --no-diff-added
]]]
Index: svn_1.2_releasenotes.html
===================================================================
--- svn_1.2_releasenotes.html   (revision 13955)
+++ svn_1.2_releasenotes.html   (working copy)
@@ -323,9 +323,9 @@
       <dt><tt>svnversion --help</tt></dt>
       <dd>Show help on <tt>svnversion</tt>.</dd>
 
-      <dt><tt>svnlook diff --no-diff-deleted</tt></dt>
+      <dt><tt>svnlook diff --no-diff-added</tt></dt>
       <dd>Don't show deleted files in the diffs.  Companion to
-          <tt>--no-diff-added</tt>.</dd>
+          <tt>--no-diff-deleted</tt>.</dd>
 
       <dt><tt>svnlook propget/proplist --revprop</tt></dt>
       <dd>Examine revision props, instead of normal versioned 
properties.</dd>

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs. 
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] - Mistake in 1.2 Release Notes - correction

Posted by Max Bowsher <ma...@ukf.net>.
Mark Phippard wrote:
> Julian Foad <ju...@btopenworld.com> wrote on 04/06/2005 04:18:21 PM:
>
>> Mark Phippard wrote:
>>> [[[
>>> Correct new command line switch for svnlook diff.
>>
>> It's not the command-line switch that you're correcting, but the
> references to
>> it in the release notes.  I'd suggest as a log message summary something
> like:
>>
>>    Correction to the release notes.
>
> OK.  I will commit with a message along those lines.

Julian didn't actually say "approved" or "+1", so technically you shouldn't 
really have committed this yet.

On the other hand, thanks for sorting out the patch, and to clear things up, 
I'll retro-actively say "+1" to this change.

Just check to see if a committer's message is a comment or an approval a 
little more carefully in future.

(And always include "Approved by: <username>" in log messages of approved 
commits).

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] - Mistake in 1.2 Release Notes - correction

Posted by Mark Phippard <Ma...@softlanding.com>.
Julian Foad <ju...@btopenworld.com> wrote on 04/06/2005 04:18:21 PM:

> Mark Phippard wrote:
> > [[[
> > Correct new command line switch for svnlook diff.
> 
> It's not the command-line switch that you're correcting, but the 
references to 
> it in the release notes.  I'd suggest as a log message summary something 
like:
> 
>    Correction to the release notes.

OK.  I will commit with a message along those lines.

Mark


_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs. 
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] - Mistake in 1.2 Release Notes - correction

Posted by Julian Foad <ju...@btopenworld.com>.
Mark Phippard wrote:
> [[[
> Correct new command line switch for svnlook diff.

It's not the command-line switch that you're correcting, but the references to 
it in the release notes.  I'd suggest as a log message summary something like:

   Correction to the release notes.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] - Mistake in 1.2 Release Notes - correction

Posted by Mark Phippard <Ma...@softlanding.com>.
I forgot to update the description in the previous patch.  Here is the new 
correct one:

[[[
Correct new command line switch for svnlook diff.
 
 * www/svn_1.2_releasenotes.html
   Flipped references to --no-diff-deleted and --no-diff-added
 ]]]
Index: svn_1.2_releasenotes.html
===================================================================
--- svn_1.2_releasenotes.html   (revision 13955)
+++ svn_1.2_releasenotes.html   (working copy)
@@ -323,9 +323,9 @@
       <dt><tt>svnversion --help</tt></dt>
       <dd>Show help on <tt>svnversion</tt>.</dd>
 
-      <dt><tt>svnlook diff --no-diff-deleted</tt></dt>
-      <dd>Don't show deleted files in the diffs.  Companion to
-          <tt>--no-diff-added</tt>.</dd>
+      <dt><tt>svnlook diff --no-diff-added</tt></dt>
+      <dd>Don't show added files in the diffs.  Companion to
+          <tt>--no-diff-deleted</tt>.</dd>
 
       <dt><tt>svnlook propget/proplist --revprop</tt></dt>
       <dd>Examine revision props, instead of normal versioned 
properties.</dd>


_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs. 
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org