You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Dave Leatherdale (JIRA)" <ji...@apache.org> on 2008/07/07 23:18:31 UTC
[jira] Created: (CXF-1692) cfx-codegen-plugin: Should be possible
to configure using named parameters.
cfx-codegen-plugin: Should be possible to configure using named parameters.
---------------------------------------------------------------------------
Key: CXF-1692
URL: https://issues.apache.org/jira/browse/CXF-1692
Project: CXF
Issue Type: Improvement
Components: Tooling
Affects Versions: 2.1.1
Reporter: Dave Leatherdale
It should not be necessary to use extraargs to configure parameters named parameter should be used instead. Extraargs should remain for unusual circumstances and backwards compatibility.
The options are configured as follows:
<defaultOptions>
<packagenames>
<packagename>packagename</packagename>
</packagenames>
<defaultExcludesNamespace>true</defaultExcludesNamespace>
<defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
<wsdlLocation></wsdlLocation>
<frontEnd>jaxws</frontEnd>
<dataBinding>jaxb</dataBinding>
<wsdlVersion>1.1</wsdlVersion>
<catalog>catalog</catalog>
<extendedSoapHeaders>true</extendedSoapHeaders>
<validateWsdl>true</validateWsdl>
<serviceName>serviceName</serviceName>
<autoNameResolution>true</autoNameResolution>
<noAddressBinding>true</noAddressBinding>
</defaultOptions>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-1692) cfx-codegen-plugin: Should be possible
to configure using named parameters.
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved CXF-1692.
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.8
2.1.2
Assignee: Daniel Kulp
> cfx-codegen-plugin: Should be possible to configure using named parameters.
> ---------------------------------------------------------------------------
>
> Key: CXF-1692
> URL: https://issues.apache.org/jira/browse/CXF-1692
> Project: CXF
> Issue Type: Improvement
> Components: Tooling
> Affects Versions: 2.1.1
> Reporter: Dave Leatherdale
> Assignee: Daniel Kulp
> Fix For: 2.1.2, 2.0.8
>
> Attachments: 1692.diff
>
>
> It should not be necessary to use extraargs to configure parameters named parameter should be used instead. Extraargs should remain for unusual circumstances and backwards compatibility.
> The options are configured as follows:
> <defaultOptions>
> <packagenames>
> <packagename>packagename</packagename>
> </packagenames>
> <defaultExcludesNamespace>true</defaultExcludesNamespace>
> <defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
> <wsdlLocation></wsdlLocation>
> <frontEnd>jaxws</frontEnd>
> <dataBinding>jaxb</dataBinding>
> <wsdlVersion>1.1</wsdlVersion>
> <catalog>catalog</catalog>
> <extendedSoapHeaders>true</extendedSoapHeaders>
> <validateWsdl>true</validateWsdl>
> <serviceName>serviceName</serviceName>
> <autoNameResolution>true</autoNameResolution>
> <noAddressBinding>true</noAddressBinding>
> </defaultOptions>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1692) cfx-codegen-plugin: Should be possible
to configure using named parameters.
Posted by "Dave Leatherdale (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611391#action_12611391 ]
Dave Leatherdale commented on CXF-1692:
---------------------------------------
Absolutely agree that extraargs can still be useful. This set should probably only include the most important ones (although doing most of them while i was in the area was fairly easy hence it's a reasonably complete set).
It's a shame maven doesn't seem to document the parameters of these classes the same way it does the mojo parameters themselves.
A lot of the command line options have long options as well as short ones (although not all when i had a look) so we may be able to use those names (perhaps adding some more along the way) . We could use mavens Map parameter support to supply a lot of the command line parameters so <extraarg>-fe</extraarg><extraarg>jaxws</extraarg> could still be written as <frontend>jaxws</frontend> it wouldn't be able to cope with everything. For instance would be fairly easy to cope with either parameters with no arguments (e.g. -validate) OR with parameters with potentially empty parameters (e.g. -wsdlLocation "") but not both without some metadata on what "style" each parameter is at which point we come back to having to maintaining that. Also not sure if we can do lists of things in map parameters.
> cfx-codegen-plugin: Should be possible to configure using named parameters.
> ---------------------------------------------------------------------------
>
> Key: CXF-1692
> URL: https://issues.apache.org/jira/browse/CXF-1692
> Project: CXF
> Issue Type: Improvement
> Components: Tooling
> Affects Versions: 2.1.1
> Reporter: Dave Leatherdale
> Attachments: 1692.diff
>
>
> It should not be necessary to use extraargs to configure parameters named parameter should be used instead. Extraargs should remain for unusual circumstances and backwards compatibility.
> The options are configured as follows:
> <defaultOptions>
> <packagenames>
> <packagename>packagename</packagename>
> </packagenames>
> <defaultExcludesNamespace>true</defaultExcludesNamespace>
> <defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
> <wsdlLocation></wsdlLocation>
> <frontEnd>jaxws</frontEnd>
> <dataBinding>jaxb</dataBinding>
> <wsdlVersion>1.1</wsdlVersion>
> <catalog>catalog</catalog>
> <extendedSoapHeaders>true</extendedSoapHeaders>
> <validateWsdl>true</validateWsdl>
> <serviceName>serviceName</serviceName>
> <autoNameResolution>true</autoNameResolution>
> <noAddressBinding>true</noAddressBinding>
> </defaultOptions>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1692) cfx-codegen-plugin: Should be possible
to configure using named parameters.
Posted by "Dave Leatherdale (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611356#action_12611356 ]
Dave Leatherdale commented on CXF-1692:
---------------------------------------
I have excluded some options either things which don't make sense in the maven plugin (help compile settings etc) or those which are used as one shot options (-client etc) which also make little sense in the context of a maven repeatable build.
> cfx-codegen-plugin: Should be possible to configure using named parameters.
> ---------------------------------------------------------------------------
>
> Key: CXF-1692
> URL: https://issues.apache.org/jira/browse/CXF-1692
> Project: CXF
> Issue Type: Improvement
> Components: Tooling
> Affects Versions: 2.1.1
> Reporter: Dave Leatherdale
> Attachments: 1692.diff
>
>
> It should not be necessary to use extraargs to configure parameters named parameter should be used instead. Extraargs should remain for unusual circumstances and backwards compatibility.
> The options are configured as follows:
> <defaultOptions>
> <packagenames>
> <packagename>packagename</packagename>
> </packagenames>
> <defaultExcludesNamespace>true</defaultExcludesNamespace>
> <defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
> <wsdlLocation></wsdlLocation>
> <frontEnd>jaxws</frontEnd>
> <dataBinding>jaxb</dataBinding>
> <wsdlVersion>1.1</wsdlVersion>
> <catalog>catalog</catalog>
> <extendedSoapHeaders>true</extendedSoapHeaders>
> <validateWsdl>true</validateWsdl>
> <serviceName>serviceName</serviceName>
> <autoNameResolution>true</autoNameResolution>
> <noAddressBinding>true</noAddressBinding>
> </defaultOptions>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-1692) cfx-codegen-plugin: Should be possible
to configure using named parameters.
Posted by "Dave Leatherdale (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Leatherdale updated CXF-1692:
----------------------------------
Attachment: 1692.diff
Patch to enable additional named options
> cfx-codegen-plugin: Should be possible to configure using named parameters.
> ---------------------------------------------------------------------------
>
> Key: CXF-1692
> URL: https://issues.apache.org/jira/browse/CXF-1692
> Project: CXF
> Issue Type: Improvement
> Components: Tooling
> Affects Versions: 2.1.1
> Reporter: Dave Leatherdale
> Attachments: 1692.diff
>
>
> It should not be necessary to use extraargs to configure parameters named parameter should be used instead. Extraargs should remain for unusual circumstances and backwards compatibility.
> The options are configured as follows:
> <defaultOptions>
> <packagenames>
> <packagename>packagename</packagename>
> </packagenames>
> <defaultExcludesNamespace>true</defaultExcludesNamespace>
> <defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
> <wsdlLocation></wsdlLocation>
> <frontEnd>jaxws</frontEnd>
> <dataBinding>jaxb</dataBinding>
> <wsdlVersion>1.1</wsdlVersion>
> <catalog>catalog</catalog>
> <extendedSoapHeaders>true</extendedSoapHeaders>
> <validateWsdl>true</validateWsdl>
> <serviceName>serviceName</serviceName>
> <autoNameResolution>true</autoNameResolution>
> <noAddressBinding>true</noAddressBinding>
> </defaultOptions>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1692) cfx-codegen-plugin: Should be possible
to configure using named parameters.
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611374#action_12611374 ]
Glen Mazza commented on CXF-1692:
---------------------------------
I disagree with the principle of this--extraargs should be equivalent to those command-line parameters of the wsdl2java tool, 1-to-1 with ideally zero difference. That's what provides the easiest and fastest upgrading and downgrading between command-line and Maven, and between Maven and the raw Ant <java/> task. [1]
Yes, the params above are prettier, but now we need to document their names (and keep maintaining them as we add more settings in), and now those graduating from command-line to Maven usage (or needing to downgrade quickly to command line for debugging purposes) have to keep doing annoying dictionary lookups to map between the two. We made that mistake in the past with our pretty-name Ant tasks[2], meant as a replacement for the uglier (relying on command-line options) raw Ant <java/> task--the pretty-name Ant tasks have fallen behind and nobody's been maintaining them.
However, I would have less problem with this change if we can still rely on extraargs in addition to these new prettier terms, and also, if the Ant task used the same parameter names as the ones you're proposing above (i.e., keep the pretty names consistent between the Ant task and the what you're proposing above--either changing the Ant task values or those of your Maven ones above for consistency.)
Thanks,
Glen
[1] http://cwiki.apache.org/CXF20DOC/wsdl-to-java.html#WSDLtoJava-usingant
[2] http://cwiki.apache.org/CXF20DOC/ant-tasks.html
> cfx-codegen-plugin: Should be possible to configure using named parameters.
> ---------------------------------------------------------------------------
>
> Key: CXF-1692
> URL: https://issues.apache.org/jira/browse/CXF-1692
> Project: CXF
> Issue Type: Improvement
> Components: Tooling
> Affects Versions: 2.1.1
> Reporter: Dave Leatherdale
> Attachments: 1692.diff
>
>
> It should not be necessary to use extraargs to configure parameters named parameter should be used instead. Extraargs should remain for unusual circumstances and backwards compatibility.
> The options are configured as follows:
> <defaultOptions>
> <packagenames>
> <packagename>packagename</packagename>
> </packagenames>
> <defaultExcludesNamespace>true</defaultExcludesNamespace>
> <defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
> <wsdlLocation></wsdlLocation>
> <frontEnd>jaxws</frontEnd>
> <dataBinding>jaxb</dataBinding>
> <wsdlVersion>1.1</wsdlVersion>
> <catalog>catalog</catalog>
> <extendedSoapHeaders>true</extendedSoapHeaders>
> <validateWsdl>true</validateWsdl>
> <serviceName>serviceName</serviceName>
> <autoNameResolution>true</autoNameResolution>
> <noAddressBinding>true</noAddressBinding>
> </defaultOptions>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.