[GitHub] [iceberg] wmoustafa commented on a diff in pull request #6004: Data: Support reading default values from generic Avro readers

["wmoustafa (via GitHub)" <gi...@apache.org>]

wmoustafa commented on code in PR #6004:
URL: https://github.com/apache/iceberg/pull/6004#discussion_r1194167594


##########
core/src/test/java/org/apache/iceberg/avro/TestAvroNameMapping.java:
##########
@@ -205,7 +205,7 @@ public void testMissingRequiredFields() {
     AssertHelpers.assertThrows(
         "Missing required field in nameMapping",
         IllegalArgumentException.class,
-        "Missing required field: x",
+        "Missing required field that doesn't have a default value: x",

Review Comment:
   I am saying `Missing required field with no default` could give the impression that the fix is by adding a default value; however, in fact the fix is either by adding the field or adding a default value. Hence, if we leave it at `Missing required field` could be adequate. We could also say `Missing required field, or missing default value`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org