You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by GitBox <gi...@apache.org> on 2020/07/21 11:44:44 UTC
[GitHub] [directory-kerby] liujiayi771 opened a new pull request #48: DIRKRB-746
liujiayi771 opened a new pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48
The remote kadmin tool of HAS should only allow the principal of kadmin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-kerby] plusplusjiajia commented on pull request #48: DIRKRB-746
Posted by GitBox <gi...@apache.org>.
plusplusjiajia commented on pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48#issuecomment-667966993
LGTM. I will merge the PR. Thanks for your contribution. @liujiayi771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-kerby] liujiayi771 closed pull request #48: DIRKRB-746
Posted by GitBox <gi...@apache.org>.
liujiayi771 closed pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-kerby] liujiayi771 commented on pull request #48: DIRKRB-746
Posted by GitBox <gi...@apache.org>.
liujiayi771 commented on pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48#issuecomment-666076182
> @liujiayi771 As we discussed offline, do you have any improvements to avoid some configurations in Krb5LoginModule change the principal?
I have added a check for kadmin principal on the server side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-kerby] liujiayi771 commented on pull request #48: DIRKRB-746
Posted by GitBox <gi...@apache.org>.
liujiayi771 commented on pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48#issuecomment-667905243
> @liujiayi771 The TestKadminApi failed with this patch, could you look at it?
>
> 
When filter_auth_type is not kerberos, there is no need to check the admin principal. I also added the processing when the request principal is null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-kerby] plusplusjiajia commented on pull request #48: DIRKRB-746
Posted by GitBox <gi...@apache.org>.
plusplusjiajia commented on pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48#issuecomment-667770090
@liujiayi771 The TestKadminApi failed with this patch, could you look at it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-kerby] plusplusjiajia commented on pull request #48: DIRKRB-746
Posted by GitBox <gi...@apache.org>.
plusplusjiajia commented on pull request #48:
URL: https://github.com/apache/directory-kerby/pull/48#issuecomment-664756314
@liujiayi771 As we discussed offline, do you have any improvements to avoid some configurations in Krb5LoginModule change the principal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org