You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/16 03:03:28 UTC
[GitHub] [rocketmq] sunxi92 opened a new issue #2817: The logic of the the broker's handling of RequestCode.QUERY_DATA_VERSION responses needs to be modified
sunxi92 opened a new issue #2817:
URL: https://github.com/apache/rocketmq/issues/2817
When a broker registers routing information with a cluster of nameservers, the broker needs to decide whether it is necessary to register routing information with a cluster of nameservers, by sending requests to the cluster to compare whether they have the same version of data.
Nameserver cluster receives a request, and after comparing the versions of the data, it will give feedback on the changed property of the header in the response. This value must not be null, so the broker only needs to decode the changed property of the response message.
So, I think the method needRegister(..) of BrokerOuterAPI.java can delete the code that decode the body of the response. In addition，the return value of the method needRegister(...) of BrokerController.java can depend on whether the size of the changedList is greater than 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] sunxi92 commented on issue #2817: The logic of the the broker's handling of RequestCode.QUERY_DATA_VERSION responses needs to be modified
Posted by GitBox <gi...@apache.org>.
sunxi92 commented on issue #2817:
URL: https://github.com/apache/rocketmq/issues/2817#issuecomment-820899156
two problems:
(1)when broker receives namesrv's response, there is no need to decode the body of the response
(2) in the reponse that the namesrv returns, changed will not be null, it's true or false
Since the changedList only obatain the value of Boolean.TRUE, so we only judge whether the size of changedList is greater than 0 instead of loop the list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #2817: The logic of the the broker's handling of RequestCode.QUERY_DATA_VERSION responses needs to be modified
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #2817:
URL: https://github.com/apache/rocketmq/issues/2817#issuecomment-820883165
double check。if not change，But there is topic update on the broker side, so you need to wait for the next time to update namesrv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org