You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/24 12:07:41 UTC
[GitHub] [skywalking] keiranmraine opened a new issue #7552: pyx files (cython)
keiranmraine opened a new issue #7552:
URL: https://github.com/apache/skywalking/issues/7552
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
### Requirement or improvement
Please can one or more of the following be added to the sykwalking-eyes functionality (or expansion of docs if already available):
* Runtime extensions equivalence via CLI (py=~pyx)
* Ability to define extension equivalence in the `.licenserc.yaml`
* Add common cython file extentions to core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] keiranmraine commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
keiranmraine commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905281672
According to the current main branch the `.pyx` extension is supported:
https://github.com/apache/skywalking-eyes/blob/082ccc7d63f8cde9afdb6eee30843b8f0a8182ed/assets/languages.yaml#L1090
The it appears that although it works for `check` it fails for `fix:
`check` - identifies file needs update:
```
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
...
INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0
ERROR the following files don't have a valid license header:
pygas/matrix.pyx
```
`fix` - indicates unsupported:
```
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0
ERROR unsupported file: pygas/matrix.pyx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-912187208
> @kezhenxu94 Is this done?
Fixed by https://github.com/apache/skywalking-eyes/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905334430
> FYI if you find people are unable to build the docker file this will solve the problem for them:
>
>
>
> https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2
>
>
>
> Created: https://github.com/apache/skywalking-eyes/pull/62
Thanks for the information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-912186773
@kezhenxu94 Is this done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7552:
URL: https://github.com/apache/skywalking/issues/7552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] keiranmraine edited a comment on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
keiranmraine edited a comment on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905281672
According to the current main branch the `.pyx` extension is supported:
https://github.com/apache/skywalking-eyes/blob/082ccc7d63f8cde9afdb6eee30843b8f0a8182ed/assets/languages.yaml#L1090
It appears that although it works for `check` it fails for `fix:
`check` - identifies file needs update:
```
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
...
INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0
ERROR the following files don't have a valid license header:
pygas/matrix.pyx
```
`fix` - indicates unsupported:
```
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0
ERROR unsupported file: pygas/matrix.pyx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-904582702
@keiranmraine can you read https://github.com/apache/skywalking-eyes#supported-file-types and try to contribute to this enhancement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905284381
@keiranmraine yes, `check` is generally available for most (if not all) programming languages, but `fix` need to know what's the comment style of a specific language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] keiranmraine commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
keiranmraine commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905289744
Ah, okay so it needs a section like the Python one creating for Cython. I'll look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] keiranmraine commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
keiranmraine commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905283126
Repo/file in example can be found here:
https://github.com/cancerit/pygas/blob/develop/pygas/matrix.pyx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] keiranmraine commented on issue #7552: [License-Eye] pyx files (cython)
Posted by GitBox <gi...@apache.org>.
keiranmraine commented on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905333518
FYI if you find people are unable to build the docker file this will solve the problem for them:
https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2
Created: https://github.com/apache/skywalking-eyes/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org