You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/24 18:27:31 UTC

[GitHub] [tvm] tmoreau89 opened a new pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

tmoreau89 opened a new pull request #7516:
URL: https://github.com/apache/tvm/pull/7516


   This adds the autoscheduler layout rewrite pass to VM compiler, to brings big performance improvements to any autoscheduler optimized graph. Tested on SSD Resnet34 and saw over 2x speedup.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] merrymercy commented on pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

Posted by GitBox <gi...@apache.org>.
merrymercy commented on pull request #7516:
URL: https://github.com/apache/tvm/pull/7516#issuecomment-786323050


   How can we address this kind of issue in the future?
   
   Should we organize the optimization passes in `src/relay/backend/vm/compiler.cc` and `src/relay/backend/build_module.cc` into a common place? So we don't need to add them in two places every time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 commented on pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7516:
URL: https://github.com/apache/tvm/pull/7516#issuecomment-788150986


   @merrymercy please let me know if there are any outstanding changes requested of if we can go ahead and merge this one


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 commented on pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7516:
URL: https://github.com/apache/tvm/pull/7516#issuecomment-786332326


   @merrymercy I think that initially the intent for Relay VM compilation was to use the same passes as the graph runtime. I think that the pass manager refactor ended up being applied to graph runtime and not the VM IIRC causing the two to diverge?
   @jroesch and @tkonolige has some input on this and we could think of a plan to unify the passes since technically the two runtimes should use the same passes. This could use an RFC but I think everyone will be behind it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 merged pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7516:
URL: https://github.com/apache/tvm/pull/7516


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] merrymercy edited a comment on pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

Posted by GitBox <gi...@apache.org>.
merrymercy edited a comment on pull request #7516:
URL: https://github.com/apache/tvm/pull/7516#issuecomment-786323050






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 commented on pull request #7516: [Autoscheduler][VM] Autoscheduler layout rewrite pass to VM

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7516:
URL: https://github.com/apache/tvm/pull/7516#issuecomment-785281079


   @junrushao1994 @merrymercy @masahi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org