You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/15 00:38:12 UTC

[GitHub] [kafka] vitojeng opened a new pull request #8871: MINOR: code cleanup for inconsistent naming

vitojeng opened a new pull request #8871:
URL: https://github.com/apache/kafka/pull/8871


   There are two kind of value naming  of valueSerde in Streams module: valSerde / valueSerde.
   No function has been changed in PR, only renamed **valSerde** to **valueSerde**.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-645090904


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-645022262






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-644483903


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-646365697


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-645022501


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-646872790


   Thanks for the cleanup @vitojeng!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax merged pull request #8871: MINOR: code cleanup for inconsistent naming

Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #8871:
URL: https://github.com/apache/kafka/pull/8871


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org