You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/05/18 13:56:41 UTC
Review Request 59369: Reduce Dependency on Cluster Desired Stack ID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-21059
https://issues.apache.org/jira/browse/AMBARI-21059
Repository: ambari
Description
-------
With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a4f59a58eb
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9ca8ddc369
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java c3691bfa88
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 9098cf1da8
ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 281523a660
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 4ed7685ae3
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b8a2
ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
Diff: https://reviews.apache.org/r/59369/diff/1/
Testing
-------
Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
Automated pending unit test fixes.
Thanks,
Nate Cole
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
> > Lines 200-202 (original), 194-195 (patched)
> > <https://reviews.apache.org/r/59369/diff/1/?file=1723987#file1723987line200>
> >
> > Just making sure this returns the same value. One doesn't return the name and the other the display name, right?
I hate this code. We should never use _just_ the component name.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
-----------------------------------------------------------
On May 18, 2017, 9:56 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 9:56 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
>
> Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a4f59a58eb
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9ca8ddc369
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java c3691bfa88
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 9098cf1da8
> ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 281523a660
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 4ed7685ae3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b8a2
> ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
>
>
> Diff: https://reviews.apache.org/r/59369/diff/1/
>
>
> Testing
> -------
>
> Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
>
> Automated pending unit test fixes.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
> > Lines 1126 (patched)
> > <https://reviews.apache.org/r/59369/diff/1/?file=1723973#file1723973line1143>
> >
> > Can you annotate this method declaration as being temporary? It should eventually not be needed, right?
This was added because we do the same checking on both the validation and the processing. I had missed code in one of the spots and had enough.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
-----------------------------------------------------------
On May 18, 2017, 9:56 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 9:56 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
>
> Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a4f59a58eb
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9ca8ddc369
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java c3691bfa88
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 9098cf1da8
> ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 281523a660
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 4ed7685ae3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b8a2
> ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
>
>
> Diff: https://reviews.apache.org/r/59369/diff/1/
>
>
> Testing
> -------
>
> Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
>
> Automated pending unit test fixes.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
> > Lines 224-230 (original), 225-237 (patched)
> > <https://reviews.apache.org/r/59369/diff/1/?file=1723971#file1723971line225>
> >
> > I think I changed this already in my commit. We shouldn't be used stack ID to find the repos; we should just get them all.
I'll pull and see how this was changed.
> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
> > Lines 216-227 (patched)
> > <https://reviews.apache.org/r/59369/diff/1/?file=1723985#file1723985line216>
> >
> > This seems temporary since it can't guarantee uniqueness? Can we mark this with an annotation to remove it later on?
Yep. If all we have is version, then it's all we can go on. This was to workaround what the UI was providing, but once we have the id, well, we have it.
> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> > Lines 777-783 (patched)
> > <https://reviews.apache.org/r/59369/diff/1/?file=1723991#file1723991line779>
> >
> > In our world, this seems OK since for every service's stack, there should only be 1 entry. (Like 2.5 for ZK and 2.6 for Storm) ...
> >
> > But in the multiverse of multi-everything, this could return values for ZK on 2.5 and ZK on 2.6 if both services are deployed concurrently.
> >
> > Maybe just mark this as needing attention from multi-everything people?
I'll mark it. One would hope that many ZK would be deployed, but we'd be getting them from a Service Group, which should only be one stack. In that world, I would hope that cluster.getServices() isn't the way to get a handle to the service.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
-----------------------------------------------------------
On May 18, 2017, 9:56 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 9:56 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
>
> Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a4f59a58eb
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9ca8ddc369
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java c3691bfa88
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 9098cf1da8
> ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 281523a660
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 4ed7685ae3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b8a2
> ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
>
>
> Diff: https://reviews.apache.org/r/59369/diff/1/
>
>
> Testing
> -------
>
> Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
>
> Automated pending unit test fixes.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
Lines 224-230 (original), 225-237 (patched)
<https://reviews.apache.org/r/59369/#comment248830>
I think I changed this already in my commit. We shouldn't be used stack ID to find the repos; we should just get them all.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
Lines 446-454 (original), 431-441 (patched)
<https://reviews.apache.org/r/59369/#comment248831>
Is this already being set by lines 431? Maybe just grab the reference once?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
Lines 1126 (patched)
<https://reviews.apache.org/r/59369/#comment248832>
Can you annotate this method declaration as being temporary? It should eventually not be needed, right?
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
Lines 216-227 (patched)
<https://reviews.apache.org/r/59369/#comment248833>
This seems temporary since it can't guarantee uniqueness? Can we mark this with an annotation to remove it later on?
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
Lines 200-202 (original), 194-195 (patched)
<https://reviews.apache.org/r/59369/#comment248834>
Just making sure this returns the same value. One doesn't return the name and the other the display name, right?
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
Lines 777-783 (patched)
<https://reviews.apache.org/r/59369/#comment248835>
In our world, this seems OK since for every service's stack, there should only be 1 entry. (Like 2.5 for ZK and 2.6 for Storm) ...
But in the multiverse of multi-everything, this could return values for ZK on 2.5 and ZK on 2.6 if both services are deployed concurrently.
Maybe just mark this as needing attention from multi-everything people?
- Jonathan Hurley
On May 18, 2017, 9:56 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 9:56 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
>
> Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a4f59a58eb
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9ca8ddc369
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java c3691bfa88
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 9098cf1da8
> ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 281523a660
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 4ed7685ae3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b8a2
> ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
>
>
> Diff: https://reviews.apache.org/r/59369/diff/1/
>
>
> Testing
> -------
>
> Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
>
> Automated pending unit test fixes.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175387
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On May 18, 2017, 4:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 4:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
>
> Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a4f59a58eb
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9ca8ddc369
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java c3691bfa88
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 9098cf1da8
> ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 281523a660
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 4ed7685ae3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b8a2
> ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
>
>
> Diff: https://reviews.apache.org/r/59369/diff/1/
>
>
> Testing
> -------
>
> Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
>
> Automated pending unit test fixes.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175917
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On May 23, 2017, 9:44 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 9:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
>
> Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 574afa1c86
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e373f81f6b
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6447888dde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 6027ce76f6
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 38175709db
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java cf2844bca6
> ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java e4ac23e132
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 89ec32b543
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 76de02c3e7
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java 7b7d8171a4
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java 91b3296332
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java 996f349c0c
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 1368b8d9d6
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0735d5aa40
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java d1d819fbb9
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8cfe258eae
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7b3837ef68
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 03e3e6639b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java b075b71598
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java c82c884e7a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 4d44576c5b
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java 1f2322cc4e
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java 66e62a0e07
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 24fd47bd05
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 710e4e7cd6
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 4ca20701f7
> ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java d2cc3454c1
> ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleGraphTest.java 303ee89a33
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 469e8c8212
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryActionTest.java fbad1b1d4c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java b06117b47e
> ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java 70631475ec
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 4437e6062e
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1709da8846
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 4c9ffcc605
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java f5f4e10590
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java e7516e6f9b
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java ec5eef02c0
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 022cf1f96a
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java c643b2f969
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 0678a71869
> ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java f996aac0d7
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java d5c1b1a68c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 1649078a85
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 6c2e9f7c95
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java 896602b54c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java c949ca2762
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java 6b28846ca3
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java eda232b29c
> ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62
>
>
> Diff: https://reviews.apache.org/r/59369/diff/2/
>
>
> Testing
> -------
>
> Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
>
> Automated pending unit test fixes.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack
ID
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/
-----------------------------------------------------------
(Updated May 23, 2017, 2:44 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Changes
-------
Update for tests. _Most_ tests are passing - stabilization will be in a coming-soon patch.
Bugs: AMBARI-21059
https://issues.apache.org/jira/browse/AMBARI-21059
Repository: ambari
Description
-------
With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the notion of a cluster being bound to a specific stack. Instead, the stack ID is being pushed down to the service and component level.
Currently, upgrades tries to set the cluster desired stack ID on finalization. Eventually there will be a complete decouple of the cluster from a singular stack id. This jira covers a majority of cases in code. Until configs are refactored, we can't remove the associated stack id in its entirety.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 574afa1c86
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 36015282ea
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java a77ed75c99
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 17e1f9c138
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c6286f
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 2fc1787e17
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java 70a061cc79
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java 1e87319d84
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java a4cea3105f
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java a55a1481d6
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 4ccdc0a3d9
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 273bdaac68
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java d8dba96094
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 9fb77e8d6b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 397c1c29e1
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 96bab85b47
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e373f81f6b
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5731bcbe
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 66c1a93081
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 4ad01a54a7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6447888dde
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 24ef41a767
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 664ba42f34
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8972ca220f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 6027ce76f6
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java c69d00ba46
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c4c2ddcbae
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 264ba030f7
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java d44515cdb4
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 89d4004f4f
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 0643c94ce1
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 4d0cf92c87
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 24c460226c
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java 40ec0a1e80
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 38175709db
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java a2472b6a8c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 47abde4660
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java 7a99f09ff0
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java cf2844bca6
ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java aa53564661
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java d6cd99786c
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 05b50ab915
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 0e40254487
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 9a35bcc97f
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 3c8ef3530c
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 6bb0ffb25b
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java e4ac23e132
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java bdc4f90f89
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java a74e2a28d8
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java dbfce48e8b
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java e08b1f9ba5
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java cb1295961d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java 38ad5baaec
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java edf107a9f4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 7b7681c0fc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 90854dd346
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java 0487cd7024
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java 9cf7bbde4b
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c235cf8e08
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java f0f92537c0
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 8488795eac
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 0125d54ac1
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 89ec32b543
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 76de02c3e7
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java 7b7d8171a4
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java 91b3296332
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java 996f349c0c
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 1368b8d9d6
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0735d5aa40
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java d1d819fbb9
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8cfe258eae
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7b3837ef68
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 03e3e6639b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java b075b71598
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java c82c884e7a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 4d44576c5b
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java 1f2322cc4e
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java 66e62a0e07
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 24fd47bd05
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 710e4e7cd6
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 4ca20701f7
ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java d2cc3454c1
ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleGraphTest.java 303ee89a33
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 469e8c8212
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryActionTest.java fbad1b1d4c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java b06117b47e
ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java 70631475ec
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 4437e6062e
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1709da8846
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 4c9ffcc605
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java f5f4e10590
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java e7516e6f9b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java ec5eef02c0
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 022cf1f96a
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java d59d1d5c09
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java c643b2f969
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 0678a71869
ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java f996aac0d7
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java d5c1b1a68c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 4dd7fd9bb1
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 1649078a85
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 6c2e9f7c95
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java c705d89045
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java 896602b54c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java fc754a06fe
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java f4b3897dee
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 82ba1498de
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 70673f8114
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3cb2c47075
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java c949ca2762
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java 6b28846ca3
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java eda232b29c
ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62
Diff: https://reviews.apache.org/r/59369/diff/2/
Changes: https://reviews.apache.org/r/59369/diff/1-2/
Testing
-------
Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU.
Automated pending unit test fixes.
Thanks,
Nate Cole