You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/02/13 20:17:09 UTC

Re: [PR] Improve `HashJoinExecBuilder` to save state from previous fields [datafusion]

alamb commented on code in PR #20276:
URL: https://github.com/apache/datafusion/pull/20276#discussion_r2805931214


##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -248,16 +248,13 @@ impl JoinLeftData {
 }
 
 /// Helps to build [`HashJoinExec`].
+///
+/// Builder can be created from an existing [`HashJoinExec`] using [`From::from`].
+/// In this case, all its fields are inherited. If a field that affects the node's
+/// properties is modified, they will be automatically recomputed during the build.
 pub struct HashJoinExecBuilder {

Review Comment:
   A minor API suggestion to make this code more discoverable might be to add an explicit method to `HashJoinExec` such as `into_builder`  (and leave the From impl as well )
   
   Something like
   
   ```rust
   let builder = hash_join_exec.into_builder()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org