You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/13 10:32:42 UTC

[GitHub] [arrow] raulcd commented on a diff in pull request #14398: ARROW-18027: [Dev][Archery][Crossbow] Reuse GitHub Token

raulcd commented on code in PR #14398:
URL: https://github.com/apache/arrow/pull/14398#discussion_r994464988


##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -310,9 +308,6 @@ def asset_callback(task_name, task, asset):
               help='Crossbow repository on github to use')
 @click.option('--fetch/--no-fetch', default=True,
               help='Fetch references (branches and tags) from the remote')
-@click.option('--github-token', envvar='ARROW_GITHUB_API_TOKEN',

Review Comment:
   don't we have to remove `github_token` from the function signature too?
   ```
   def report_pr(obj, arrow_remote, crossbow, fetch, github_token, job_name,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org