You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/12/06 04:38:22 UTC

[GitHub] incubator-guacamole-client pull request #93: GUACAMOLE-136: Ensure field tem...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/93

    GUACAMOLE-136: Ensure field template is in DOM prior to invoking controller.

    Lacking these changes, custom field type controllers cannot rely on their templates being present in the DOM, and things which would normally work for Angular directives fail to work with custom field types.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-client field-template-order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit 6eda36cd4e184e87b5cc88606808fdee8414803b
Author: Michael Jumper <mj...@apache.org>
Date:   2016-12-01T08:52:57Z

    GUACAMOLE-136: Ensure field template is in DOM prior to invoking controller.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #93: GUACAMOLE-136: Ensure field tem...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/93


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---