You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/19 23:46:54 UTC
[GitHub] [incubator-superset] benceorlai opened a new issue #11759: x-ing out Annotation Layer type makes the page blank
benceorlai opened a new issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759
### Expected results
Layer type resets to default
### Actual results
The entire page goes blank
#### Screenshots
#### How to reproduce the bug
1. Open a Chart in Explore
1. Click + Add Annotation Layer
1. Click on the little x next to Formula in the ANNOTATION LAYER TYPE
1. See the whole page go blank
### Environment
(please complete the following information):
- superset version: master sha 676e0bb28211ec8e588abb8898924771d3dd6f32
- python version:
- node.js version:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730710448
we should just kill the `x` as it's really not needed.. appreciate anyone can throw a quick fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-732589177
It's also possible/easy to remove the `x` by setting the prop `clearable: false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730710448
Expected behavior: user click `x` to exit annotation modal and go back to the panel
we should just kill the `x`s in the drop down menus as they are really not needed.. appreciate anyone who can throw a quick fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730710448
Expected behavior: user click `x` to exit annotation modal and go back to explore
we should just kill the `x`s in the drop down menus as they are really not needed.. appreciate anyone who can throw a quick fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730710448
Expected behavior: user click `x` to exit annotation modal and go back to the panel
we should just kill the `x` as it's really not needed.. appreciate anyone who can throw a quick fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
ktmud closed issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-732434603
>i think the expected behavior of that x is to reset the value of the dropdown to its default, not to close out the popover.
closing the modal is what the other Xs do in the same modal currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai commented on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
benceorlai commented on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-731210769
at the risk of nitpicking, i think the expected behavior of that x is to reset the value of the dropdown to its default, not to close out the popover. the real issue though is the page blankout, which I think is quite serious (although an edge case)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730710448
we should just kill the `x` as it's really not needed.. appreciate anyone who can throw a quick fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730710448
Expected behavior: user click `x` to exit annotation modal and go back to the panel
we should just kill the `x`s in the drop down as they are really not needed.. appreciate anyone who can throw a quick fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11759: x-ing out Annotation Layer type makes the page blank
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11759:
URL: https://github.com/apache/incubator-superset/issues/11759#issuecomment-730714595
We should also handle the fact that the explore page goes completely blank when there's an error. I think we just need to wrap the explore page in an `ErrorBoundary`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org