You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zyfeier (via GitHub)" <gi...@apache.org> on 2023/07/31 03:23:01 UTC
[GitHub] [nuttx] zyfeier opened a new pull request, #9959: arch: update g_running_tasks when context switch occurred
zyfeier opened a new pull request, #9959:
URL: https://github.com/apache/nuttx/pull/9959
## Summary
When supporting high-priority interrupts, updating the g_running_tasks within a high-priority interrupt may be cause problems. The g_running_tasks should only be updated when it is determined that a task context switch has occurred.
## Impact
assert
## Testing
bes board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] zyfeier commented on a diff in pull request #9959: arch: update g_running_tasks when context switch occurred
Posted by "zyfeier (via GitHub)" <gi...@apache.org>.
zyfeier commented on code in PR #9959:
URL: https://github.com/apache/nuttx/pull/9959#discussion_r1279286460
##########
arch/sim/src/sim/CMakeLists.txt:
##########
@@ -234,6 +234,7 @@ endif()
target_include_directories(nuttx PRIVATE ${CMAKE_BINARY_DIR}/include/nuttx)
target_include_directories(nuttx PRIVATE ${CMAKE_CURRENT_LIST_DIR})
+target_include_directories(sim_head PUBLIC ${NUTTX_DIR}/sched)
Review Comment:
this include_directories is for target_sources(sim_head PUBLIC sim_head.c sim_doirq.c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9959: arch: update g_running_tasks when context switch occurred
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9959:
URL: https://github.com/apache/nuttx/pull/9959#discussion_r1279234931
##########
arch/sim/src/sim/CMakeLists.txt:
##########
@@ -234,6 +234,7 @@ endif()
target_include_directories(nuttx PRIVATE ${CMAKE_BINARY_DIR}/include/nuttx)
target_include_directories(nuttx PRIVATE ${CMAKE_CURRENT_LIST_DIR})
+target_include_directories(sim_head PUBLIC ${NUTTX_DIR}/sched)
Review Comment:
don't need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9959: arch: update g_running_tasks when context switch occurred
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9959:
URL: https://github.com/apache/nuttx/pull/9959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] zyfeier commented on a diff in pull request #9959: arch: update g_running_tasks when context switch occurred
Posted by "zyfeier (via GitHub)" <gi...@apache.org>.
zyfeier commented on code in PR #9959:
URL: https://github.com/apache/nuttx/pull/9959#discussion_r1279254959
##########
arch/sim/src/sim/CMakeLists.txt:
##########
@@ -234,6 +234,7 @@ endif()
target_include_directories(nuttx PRIVATE ${CMAKE_BINARY_DIR}/include/nuttx)
target_include_directories(nuttx PRIVATE ${CMAKE_CURRENT_LIST_DIR})
+target_include_directories(sim_head PUBLIC ${NUTTX_DIR}/sched)
Review Comment:
Cmake will build fail when not add target include
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9959: arch: update g_running_tasks when context switch occurred
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9959:
URL: https://github.com/apache/nuttx/pull/9959#discussion_r1279259850
##########
arch/sim/src/sim/CMakeLists.txt:
##########
@@ -234,6 +234,7 @@ endif()
target_include_directories(nuttx PRIVATE ${CMAKE_BINARY_DIR}/include/nuttx)
target_include_directories(nuttx PRIVATE ${CMAKE_CURRENT_LIST_DIR})
+target_include_directories(sim_head PUBLIC ${NUTTX_DIR}/sched)
Review Comment:
but it's already added here?
```
https://github.com/apache/nuttx/blob/master/arch/CMakeLists.txt#L26C3-L31
```
is it strange that sim need add additional one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org