[GitHub] [maven-shade-plugin] cstamas opened a new pull request #94: Fix for Java16+

[GitBox <gi...@apache.org>]

cstamas opened a new pull request #94:
URL: https://github.com/apache/maven-shade-plugin/pull/94


   The commit fa5e40dc59355163d89cd904fcf4c4724ba3d3d6
   made build fail on Java16 due illegal reflective access.
   
   The commit is wrong that is uses "aop" guice, that is
   the culprit of illegal reflective access (on Java11
   generates a warning on system out, but Java16
   prevents it).
   
   Solution: use the "no_aop" guice instead. Also,
   there was a SLF4J warning about non existence of
   backend in tests, fixed by adding simple backend
   with test scope.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] cstamas commented on pull request #94: Fix for Java16+

[GitBox <gi...@apache.org>]

cstamas commented on pull request #94:
URL: https://github.com/apache/maven-shade-plugin/pull/94#issuecomment-845784311


   merged as 02fba3ab6712092076b9071b4c411826c7ebd53d


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] cstamas closed pull request #94: Fix for Java16+

[GitBox <gi...@apache.org>]

cstamas closed pull request #94:
URL: https://github.com/apache/maven-shade-plugin/pull/94


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org