You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2019/03/05 21:53:02 UTC

[jira] [Commented] (RATIS-494) Throw AssumptionViolatedException if a test fails to change leader

    [ https://issues.apache.org/jira/browse/RATIS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784951#comment-16784951 ] 

Jitendra Nath Pandey commented on RATIS-494:
--------------------------------------------

+1, LGTM.

> Throw AssumptionViolatedException if a test fails to change leader
> ------------------------------------------------------------------
>
>                 Key: RATIS-494
>                 URL: https://issues.apache.org/jira/browse/RATIS-494
>             Project: Ratis
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: r494_20190305.patch
>
>
> In some (unlucky) cases, tests may fail to change leader which leads to a failure.  Testing leader change is not an objective of the particular tests.  When leader change fails, these tests becomes meaningless.
> We may throw AssumptionViolatedException (new in junit 4.12) so that failing to change leader won't generate a test case failure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)