[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1412: ORC-1373: Add log when DynamicByteArray length overflow

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1412:
URL: https://github.com/apache/orc/pull/1412#discussion_r1108054899


##########
java/core/src/java/org/apache/orc/impl/DynamicByteArray.java:
##########
@@ -59,10 +65,16 @@ private void grow(int chunkIndex) {
         int newSize = Math.max(chunkIndex + 1, 2 * data.length);
         data = Arrays.copyOf(data, newSize);
       }
-      for(int i=initializedChunks; i <= chunkIndex; ++i) {
+      for (int i = initializedChunks; i <= chunkIndex; ++i) {
         data[i] = new byte[chunkSize];
       }
       initializedChunks = chunkIndex + 1;
+    } else if (chunkIndex < 0) {
+      LOG.error("chunkIndex overflow:{}. You can adjust the relevant configuration: {},{}.",

Review Comment:
   Thank you for adding this. Can we give some directional hints how to adjust those configurations, @cxzl25 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org