You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/27 16:20:01 UTC
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9023: LESS is more
etr2460 commented on a change in pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#discussion_r371337024
##########
File path: superset/assets/src/SqlLab/main.less
##########
@@ -321,10 +321,9 @@ div.Workspace {
div.tablePopover {
opacity: 0.7 !important;
-}
-
-div.tablePopover:hover {
- opacity: 1 !important;
+ &:hover {
Review comment:
this is a styling thing, but personally i prefer a new line between normal styles and the `&:foo {` line. I think there's a way to lint for that, if so maybe you could add that rule in another PR. if not, maybe we could start standardizing that here if you agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org