You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/25 11:08:53 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15296: [Improve][txn] Add admin api updateTransactionCoordinatorNumber

Technoboy- commented on code in PR #15296:
URL: https://github.com/apache/pulsar/pull/15296#discussion_r857511592


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java:
##########
@@ -178,6 +178,17 @@ void run() throws Exception {
         }
     }
 
+    @Parameters(commandDescription = "Update the scale of transaction coordinators")
+    private class ScaleTransactionCoordinators extends CliCommand {
+        @Parameter(names = { "-r", "--replicas" }, description = "The scale of the transaction coordinators")
+        private int replicas;

Review Comment:
   Which name is better, `partitions` or `replicas` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org