[GitHub] [tinkerpop] spmallette opened pull request #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

["spmallette (GitHub)" <gi...@apache.org>]

https://issues.apache.org/jira/browse/TINKERPOP-2134

I bumped this a long time ago - actually started with 2.5.5, but that version seemed to do something unstable to spark for some reason?? before i had time to really investigate 2.5.6 came out so I figured I'd just try that. The spark issue stopped but then there was other build problems with docker so I laid off issuing the PR again. After a number of investigations/fixes around the docker failures which seemed unrelated to this Groovy change, I've finally gotten some consecutive clean docker runs. Still not completely sure that Groovy ever had anything to do with the problem. I'd appreciate if reviewers could do some docker runs themselves to see what their environments show, but other than that, I'm going to go with:

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1061 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

["robertdale (GitHub)" <gi...@apache.org>]

Building...

`sh docker/build.sh -i -t` SUCCESS

[ Full content available at: https://github.com/apache/tinkerpop/pull/1061 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

["dkuppitz (GitHub)" <gi...@apache.org>]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1061 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

["robertdale (GitHub)" <gi...@apache.org>]

Building...

`sh docker/build.sh -i -t` SUCCESS

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1061 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

["robertdale (GitHub)" <gi...@apache.org>]

Building...

[ Full content available at: https://github.com/apache/tinkerpop/pull/1061 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

["spmallette (GitHub)" <gi...@apache.org>]

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1061 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org