Re: [PR] chore: Fix no-op Transformed flags [datafusion]

["joroKr21 (via GitHub)" <gi...@apache.org>]

joroKr21 commented on code in PR #21964:
URL: https://github.com/apache/datafusion/pull/21964#discussion_r3174310403


##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -1199,18 +1207,19 @@ impl OptimizerRule for PushDownFilter {
                     .cloned()
                     .collect();
 
+                let scan_filters_changed = new_scan_filters != scan.filters;

Review Comment:
   I think that check is not enough because some predicates that were already in the scan can be eliminated from the filter when the support is exact (not partial)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org