You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/25 01:19:35 UTC
[GitHub] [airflow] kaxil opened a new pull request #14440: Bump openapi-spec-validator to 0.3
kaxil opened a new pull request #14440:
URL: https://github.com/apache/airflow/pull/14440
A new version of openapi-spec-validator was released (https://pypi.org/project/openapi-spec-validator/#history) today which broke some tests https://github.com/apache/airflow/runs/1974443463?check_suite_focus=true .
```
root@63779b6c29e8:/opt/airflow# pipdeptree --reverse --packages openapi-spec-validator
openapi-spec-validator==0.2.9
- connexion==2.7.0 [requires: openapi-spec-validator>=0.2.4]
- apache-airflow==2.1.0.dev0 [requires: connexion>=2.6.0,<3]
```
Looks like https://github.com/zalando/connexion isn't maintained that much and hence we need to bump this library ourselves and fix tests
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-848361494
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582430163
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
```suggestion
"api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
```
I'm wondering if this is a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-785539192
We also need to change:
https://github.com/apache/airflow/blob/c069e64920da780237a1e1bdd155319b007a2587/tests/api_connexion/endpoints/test_task_instance_endpoint.py#L36-L37
Previously, date-time was not validated in the open API spec. This made us create these functions: https://github.com/apache/airflow/blob/c069e64920da780237a1e1bdd155319b007a2587/airflow/api_connexion/parameters.py#L27-L46
I think now, those functions no longer work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-858762649
@kaxil is this needed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-813064980
[The Workflow run](https://github.com/apache/airflow/actions/runs/717029136) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-785516449
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy edited a comment on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy edited a comment on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-785539192
We also need to change:
https://github.com/apache/airflow/blob/c069e64920da780237a1e1bdd155319b007a2587/tests/api_connexion/endpoints/test_task_instance_endpoint.py#L36-L37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-813100710
[The Workflow run](https://github.com/apache/airflow/actions/runs/717368051) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582431618
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
Though the documentation is clear on using `Z` instead of `+00:00`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-813100793
[The Workflow run](https://github.com/apache/airflow/actions/runs/717414629) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582430212
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
I'm wondering if this is a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582430212
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
```suggestion
"api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
```
I'm wondering if this is a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582430163
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
```suggestion
"api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
```
I'm wondering if this is a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582431618
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
Though the documentation is clear on using `Z` instead of `+00:00`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-813065021
[The Workflow run](https://github.com/apache/airflow/actions/runs/717042771) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #14440:
URL: https://github.com/apache/airflow/pull/14440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy edited a comment on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy edited a comment on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-785539192
We also need to change:
https://github.com/apache/airflow/blob/c069e64920da780237a1e1bdd155319b007a2587/tests/api_connexion/endpoints/test_task_instance_endpoint.py#L36-L37
Previously, date-time was not validated in the open API spec. This made us create these functions: https://github.com/apache/airflow/blob/c069e64920da780237a1e1bdd155319b007a2587/airflow/api_connexion/parameters.py#L27-L46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#discussion_r582431496
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -399,15 +399,15 @@ class TestGetDagRunsPaginationFilters(TestDagRunEndpoint):
@parameterized.expand(
[
(
- "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00+00:00",
+ "api/v1/dags/TEST_DAG_ID/dagRuns?start_date_gte=2020-06-18T18:00:00Z",
Review comment:
Though the documentation is clear on using `Z` instead of `00+00:00`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-813600211
[The Workflow run](https://github.com/apache/airflow/actions/runs/720152253) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14440: Bump openapi-spec-validator to 0.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14440:
URL: https://github.com/apache/airflow/pull/14440#issuecomment-813599430
[The Workflow run](https://github.com/apache/airflow/actions/runs/720137413) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org