You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2011/09/07 00:13:09 UTC

[jira] [Updated] (THRIFT-1323) TFramedTransport should throw an exception that distinguishes an oversized frame from a dead client, servers should log that exception

     [ https://issues.apache.org/jira/browse/THRIFT-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-1323:
----------------------------------

    Component/s: Java - Library

Since you're talking about Cassandra, I assume this is in the Java library.

> TFramedTransport should throw an exception that distinguishes an oversized frame from a dead client, servers should log that exception
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1323
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1323
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Jim Ancona
>
> When TFramedTransport receives a frame that is larger than the maximum frame size, it throws a TTransportException. This makes that error indistinguishable from a failed client. Because such errors are common, many servers (TSimpleServer, TThreadPoolServer, and Cassandra's CustomTThreadPoolServer) swallow TTransportException without a log message, making it difficult to diagnose this problem. I'm not familiar enough with the code base to suggest which exception to throw in its place, although a subclass of TTransportException, or a new TTransportException.type_ value might work. In any case, the corresponding server implementations should log that condition when it occurs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira