You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2015/02/18 00:32:57 UTC

[GitHub] spark pull request: [SPARK-5875][SQL]logical.Project should not be...

GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/4663

    [SPARK-5875][SQL]logical.Project should not be resolved if it contains aggregates or generators

    https://issues.apache.org/jira/browse/SPARK-5875 has a case to reproduce the bug and explain the root cause.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark projectResolved

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4663
    
----
commit 472f7b6a4d40451ed5a9bf4c15622bc1d7b33f0b
Author: Yin Huai <yh...@databricks.com>
Date:   2015-02-17T23:31:25Z

    If a logical.Project has any AggregateExpression or Generator, it's resolved field should be false.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5875][SQL]logical.Project should not be...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4663#issuecomment-74790128
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27661/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5875][SQL]logical.Project should not be...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4663#issuecomment-74779809
  
      [Test build #27661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27661/consoleFull) for   PR 4663 at commit [`472f7b6`](https://github.com/apache/spark/commit/472f7b6a4d40451ed5a9bf4c15622bc1d7b33f0b).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5875][SQL]logical.Project should not be...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/4663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5875][SQL]logical.Project should not be...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4663#issuecomment-74790118
  
      [Test build #27661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27661/consoleFull) for   PR 4663 at commit [`472f7b6`](https://github.com/apache/spark/commit/472f7b6a4d40451ed5a9bf4c15622bc1d7b33f0b).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org