You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/04 17:07:55 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #1028: [DEPS][TEST] Reduce Hudi dependencies
pan3793 opened a new pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2b76b5) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c2b76b5 differs from pull request most recent head f56f5e8. Consider uploading reports for the commit f56f5e8 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.64% -0.04%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4707 -2
- Misses 734 735 +1
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...f56f5e8](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913394648
> The current ut for data lake formats only contain create and query, I think it's OK to remove the hbase deps now, and maybe hudi will have improved the deps management when we add the write test cases in the future.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2b76b5) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.64% -0.04%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4707 -2
- Misses 734 735 +1
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...c2b76b5](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702648817
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -42,5 +42,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
"spark.sql.defaultCatalog" -> catalog,
"spark.sql.extensions" -> "org.apache.spark.sql.hudi.HoodieSparkSessionExtension",
"spark.serializer" -> "org.apache.spark.serializer.KryoSerializer",
+ "hoodie.bootstrap.index.class" -> "org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex",
Review comment:
Overwriting the config when creating the table
https://hudi.apache.org/docs/quick-start-guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1028: [DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a055c41) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a055c41 differs from pull request most recent head e588c12. Consider uploading reports for the commit e588c12 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
+ Coverage 80.67% 80.81% +0.13%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
+ Hits 4709 4717 +8
+ Misses 734 723 -11
- Partials 394 397 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `54.54% <0.00%> (+16.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...e588c12](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913467961
cc @yanghua @yaooqinn
This blocks #1029 due to the hadoop dependencies from hudi, please take a look if you have time, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702736322
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -38,7 +38,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
}
override protected def extraConfigs = Map(
- "spark.sql.catalogImplementation" -> "in-memory",
Review comment:
How does Hudi community do such a Hive integration test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702749234
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -38,7 +38,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
}
override protected def extraConfigs = Map(
- "spark.sql.catalogImplementation" -> "in-memory",
Review comment:
```
spark.sql("...")
```
It works well with derby.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebcbc8f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head ebcbc8f differs from pull request most recent head 069fbac. Consider uploading reports for the commit 069fbac to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
=========================================
Coverage 80.67% 80.67%
Complexity 14 14
=========================================
Files 159 159
Lines 5837 5837
Branches 657 657
=========================================
Hits 4709 4709
Misses 734 734
Partials 394 394
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...069fbac](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef6ac47) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ef6ac47 differs from pull request most recent head ca1b20e. Consider uploading reports for the commit ca1b20e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
Misses 734 734
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...ca1b20e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913386489
@simon824 seems that HUDI test suites passed without any HBase depenedencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913467961
cc @yanghua @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5664176) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.64% -0.04%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4707 -2
- Misses 734 735 +1
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...5664176](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r703149635
##########
File path: pom.xml
##########
@@ -1034,37 +1030,81 @@
<dependency>
<groupId>org.apache.hudi</groupId>
- <artifactId>hudi-spark3_${scala.binary.version}</artifactId>
+ <artifactId>hudi-spark-common_${scala.binary.version}</artifactId>
Review comment:
+1 for introducing the common artifact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebcbc8f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head ebcbc8f differs from pull request most recent head ca1b20e. Consider uploading reports for the commit ca1b20e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
=========================================
Coverage 80.67% 80.67%
Complexity 14 14
=========================================
Files 159 159
Lines 5837 5837
Branches 657 657
=========================================
Hits 4709 4709
Misses 734 734
Partials 394 394
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...ca1b20e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebcbc8f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head ebcbc8f differs from pull request most recent head e2b8e0f. Consider uploading reports for the commit e2b8e0f to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
=========================================
Coverage 80.67% 80.67%
Complexity 14 14
=========================================
Files 159 159
Lines 5837 5837
Branches 657 657
=========================================
Hits 4709 4709
Misses 734 734
Partials 394 394
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...e2b8e0f](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702636163
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -42,5 +42,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
"spark.sql.defaultCatalog" -> catalog,
"spark.sql.extensions" -> "org.apache.spark.sql.hudi.HoodieSparkSessionExtension",
"spark.serializer" -> "org.apache.spark.serializer.KryoSerializer",
+ "hoodie.bootstrap.index.class" -> "org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex",
Review comment:
Yes, HFileBootstrapIndex is the default value, if you want reduce hbase dep, this config should be 'org.apache.hudi.common.bootstrap.index.NoOpBootstrapIndex'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702643007
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -42,5 +42,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
"spark.sql.defaultCatalog" -> catalog,
"spark.sql.extensions" -> "org.apache.spark.sql.hudi.HoodieSparkSessionExtension",
"spark.serializer" -> "org.apache.spark.serializer.KryoSerializer",
+ "hoodie.bootstrap.index.class" -> "org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex",
Review comment:
Yeah, just change it back to default for test. BTW, is it the right approach to overwrite hudi conf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913389803
> @simon824 seems that HUDI test suites passed without any HBase depenedencies
Create operation is working fine,but insert /update operation will cause exception, does ut need add insert /update operation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702689001
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -38,7 +38,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
}
override protected def extraConfigs = Map(
- "spark.sql.catalogImplementation" -> "in-memory",
Review comment:
Yeah, I see, just move it to `WithSparkSQLEngine`.
BTW, why hudi doesn't work with `hive` catalog? `in-memory` should only used for test, I think most users would use hive for production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a055c41) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a055c41 differs from pull request most recent head 5664176. Consider uploading reports for the commit 5664176 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
+ Coverage 80.67% 80.81% +0.13%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
+ Hits 4709 4717 +8
+ Misses 734 723 -11
- Partials 394 397 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `54.54% <0.00%> (+16.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...5664176](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702683369
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -38,7 +38,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
}
override protected def extraConfigs = Map(
- "spark.sql.catalogImplementation" -> "in-memory",
Review comment:
this config is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f56f5e8) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
- Misses 734 735 +1
Partials 394 394
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...f56f5e8](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41ce852) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 41ce852 differs from pull request most recent head ca1b20e. Consider uploading reports for the commit ca1b20e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
Misses 734 734
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...ca1b20e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (069fbac) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 069fbac differs from pull request most recent head e62c403. Consider uploading reports for the commit e62c403 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
- Misses 734 735 +1
Partials 394 394
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...e62c403](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913786674
Thanks, merging to master for v1.4.0 and unblock #1029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5664176) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5664176 differs from pull request most recent head c2b76b5. Consider uploading reports for the commit c2b76b5 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.64% -0.04%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4707 -2
- Misses 734 735 +1
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...c2b76b5](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702632368
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -42,5 +42,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
"spark.sql.defaultCatalog" -> catalog,
"spark.sql.extensions" -> "org.apache.spark.sql.hudi.HoodieSparkSessionExtension",
"spark.serializer" -> "org.apache.spark.serializer.KryoSerializer",
+ "hoodie.bootstrap.index.class" -> "org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex",
Review comment:
Actually, `HFileBootstrapIndex` is the default value, it's not matter with/without this conf I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f56f5e8) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f56f5e8 differs from pull request most recent head 41ce852. Consider uploading reports for the commit 41ce852 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
- Misses 734 735 +1
Partials 394 394
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...41ce852](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702722467
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -42,5 +42,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
"spark.sql.defaultCatalog" -> catalog,
"spark.sql.extensions" -> "org.apache.spark.sql.hudi.HoodieSparkSessionExtension",
"spark.serializer" -> "org.apache.spark.serializer.KryoSerializer",
+ "hoodie.bootstrap.index.class" -> "org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex",
Review comment:
Thanks, we need refactor `DataLakeSuiteMixin` and expose create table options to subclass in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702734954
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -38,7 +38,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
}
override protected def extraConfigs = Map(
- "spark.sql.catalogImplementation" -> "in-memory",
Review comment:
It works well if hive metastore is base on mysql and will cause Concurrent Exception if base on derby.
Derby is the default config value, and ut is base on it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41ce852) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
Misses 734 734
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...41ce852](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913012119
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1028](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41ce852) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/05fc1c0ba8af3138839f20eeda61daa92b2f8698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05fc1c0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 41ce852 differs from pull request most recent head da37b0f. Consider uploading reports for the commit da37b0f to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
- Coverage 80.67% 80.65% -0.02%
Complexity 14 14
============================================
Files 159 159
Lines 5837 5837
Branches 657 657
============================================
- Hits 4709 4708 -1
Misses 734 734
- Partials 394 395 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05fc1c0...da37b0f](https://codecov.io/gh/apache/incubator-kyuubi/pull/1028?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702734954
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -38,7 +38,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
}
override protected def extraConfigs = Map(
- "spark.sql.catalogImplementation" -> "in-memory",
Review comment:
It work well if hive metastore is base on mysql and will cause Concurrent Exception if base on derby.
Derby is the default config value, and ut is base on it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913962668
thought: shall we introduce the integration test for the third-party's basic function, e.g. write path & read path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#discussion_r702632368
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/HudiSuiteMixin.scala
##########
@@ -42,5 +42,6 @@ trait HudiSuiteMixin extends DataLakeSuiteMixin {
"spark.sql.defaultCatalog" -> catalog,
"spark.sql.extensions" -> "org.apache.spark.sql.hudi.HoodieSparkSessionExtension",
"spark.serializer" -> "org.apache.spark.serializer.KryoSerializer",
+ "hoodie.bootstrap.index.class" -> "org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex",
Review comment:
Actually, `HFileBootstrapIndex` is the default value, it's no matter with/without this conf I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1028: [KYUUBI #703][FOLLOWUP][DEPS][TEST] Reduce Hudi dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1028:
URL: https://github.com/apache/incubator-kyuubi/pull/1028#issuecomment-913393537
The current ut for data lake formats only contain create and query, I think it's OK to remove the hbase deps now, and maybe hudi will have improved the deps management when we add the write test cases in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org