You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/02 00:42:37 UTC
[GitHub] [ozone] fapifta opened a new pull request #3267: HDDS-6209. EC: [Forward compatibility issue] New client to older server could fail due to the unavailability for client default replication config
fapifta opened a new pull request #3267:
URL: https://github.com/apache/ozone/pull/3267
## What changes were proposed in this pull request?
The change adds a new OzoneManagerVersion against which the clients can check whether the OM is supporting EC or not.
Added check for replication config arguments in the relevant requests/commands to ensure we do not send an ECReplicationFactor instance to a cluster that does not have support for it.
The affected mutations: CreateKey, CreateFile, CreateBucket, SetBucketProperty, InitiateMultipartUpload.
These 5 places are enough as later on the replication config supplied in those are used passed and used between the client and the server.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6209
## How was this patch tested?
Current CI should cover some of the new additions here, some tests may be adjusted as part of this PR later on, but posting this so that the additional production code can already be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on a change in pull request #3267: HDDS-6209. EC: [Forward compatibility issue] New client to older server could fail due to the unavailability for client default replication config
Posted by GitBox <gi...@apache.org>.
errose28 commented on a change in pull request #3267:
URL: https://github.com/apache/ozone/pull/3267#discussion_r840994198
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/CreatePipelineSubcommand.java
##########
@@ -55,7 +55,14 @@
@Override
public void execute(ScmClient scmClient) throws IOException {
- if (type == HddsProtos.ReplicationType.CHAINED) {
+ // Once we support creating EC containers/pipelines from the client, the
+ // client should check if SCM is able to fulfil the request, and
+ // understands an EcReplicationConfig. For that we also need to have SCM's
+ // version here from ScmInfo response.
+ // As I see there is no way to specify ECReplicationConfig properly here
+ // so failing the request if type is EC, seems to be safe.
+ if (type == HddsProtos.ReplicationType.CHAINED
+ || type == HddsProtos.ReplicationType.EC) {
Review comment:
Is there a similar EC config for the create container CLI that would need to be blocked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org