You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/10 06:01:40 UTC
Review Request 67870: Fixed an incorrect type in the master's metrics
code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
Repository: mesos
Description
-------
Fixed an incorrect type in the master's metrics code.
Diffs
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
Diff: https://reviews.apache.org/r/67870/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67870: Fixed an incorrect type in the master's
metrics code.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/#review205895
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67813.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67813`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1893/mesos-review-67870
Relevant logs:
- [apply-review-67813-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1893/mesos-review-67870/logs/apply-review-67813-stdout.log):
```
error: patch failed: src/master/metrics.cpp:630
error: src/master/metrics.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On July 10, 2018, 6:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67870/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 6:01 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an incorrect type in the master's metrics code.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
>
>
> Diff: https://reviews.apache.org/r/67870/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67870: Fixed an incorrect type in the master's
metrics code.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/#review205931
-----------------------------------------------------------
The commit message seems pretty ambiguous to me. Can you update it to reflect that we're avoiding implicit construction of hashmap from std::map?
- Benjamin Mahler
On July 10, 2018, 6:23 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67870/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an incorrect type in the master's metrics code.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
>
>
> Diff: https://reviews.apache.org/r/67870/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67870: Fixed an incorrect type in the master's
metrics code.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 10, 2018, 3:56 p.m., James Peach wrote:
> > Do you think we should make the `hashmap` conversion constructor `explicit` to prevent future instances of this bug?
Yea that seems like a good idea to me. I'll submit a patch for this.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/#review205913
-----------------------------------------------------------
On July 10, 2018, 6:23 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67870/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an incorrect type in the master's metrics code.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
>
>
> Diff: https://reviews.apache.org/r/67870/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67870: Fixed an incorrect type in the master's
metrics code.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/#review205913
-----------------------------------------------------------
Fix it, then Ship it!
Do you think we should make the `hashmap` conversion constructor `explicit` to prevent future instances of this bug?
src/master/http.cpp
Line 2163 (original), 2163 (patched)
<https://reviews.apache.org/r/67870/#comment288839>
Can you please also fix this problem in `src/slave/http.cpp`?
- James Peach
On July 10, 2018, 6:23 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67870/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an incorrect type in the master's metrics code.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
>
>
> Diff: https://reviews.apache.org/r/67870/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67870: Avoided implicit construction of a hashmap
in the metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
-----------------------------------------------------------
(Updated July 12, 2018, 8:09 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
Repository: mesos
Description
-------
The master and agent metrics code was passing a `std::map` into a
continuation which accepted its parameter as a `hashmap`, leading
to the implicit construction of an extra object.
Diffs
-----
src/master/http.cpp be95d262676af8b2b2d5ea7f7aaef2acee60e748
src/slave/http.cpp acbcf7ab9810e1f78639858fa086c2a5183e908f
Diff: https://reviews.apache.org/r/67870/diff/3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67870: Avoided implicit construction of a hashmap
in the metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
-----------------------------------------------------------
(Updated July 12, 2018, 6:17 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
Summary (updated)
-----------------
Avoided implicit construction of a hashmap in the metrics.
Repository: mesos
Description (updated)
-------
The master and agent metrics code was passing a `std::map` into a
continuation which accepted its parameter as a `hashmap`, leading
to the implicit construction of an extra object.
Diffs (updated)
-----
src/master/http.cpp be95d262676af8b2b2d5ea7f7aaef2acee60e748
src/slave/http.cpp acbcf7ab9810e1f78639858fa086c2a5183e908f
Diff: https://reviews.apache.org/r/67870/diff/3/
Changes: https://reviews.apache.org/r/67870/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67870: Fixed an incorrect type in the master's
metrics code.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
-----------------------------------------------------------
(Updated July 10, 2018, 6:23 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
Repository: mesos
Description
-------
Fixed an incorrect type in the master's metrics code.
Diffs (updated)
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
Diff: https://reviews.apache.org/r/67870/diff/2/
Changes: https://reviews.apache.org/r/67870/diff/1-2/
Testing
-------
Thanks,
Greg Mann