[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #1562:
URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468646249



##########
File path: arch/arm/src/common/arm_createstack.c
##########
@@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_t ttype)
       /* Save the adjusted stack values in the struct tcb_s */
 
       tcb->adj_stack_ptr  = (uint32_t *)top_of_stack;
-      tcb->adj_stack_size = size_of_stack;
+      tcb->adj_stack_size = size_of_stack -

Review comment:
       https://github.com/apache/incubator-nuttx/blob/b256b2055f7e519104052499e6855013cb06cc5f/arch/arm/src/common/arm_createstack.c#L237-L238
   Then, this needs to be adjusted too?  No need to take sizeof(tls_info_s) off anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org