You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2013/10/17 14:50:28 UTC
svn commit: r1533064 - in
/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2:
TestKeyedObjectPool.java TestObjectPool.java
impl/TestGenericKeyedObjectPool.java impl/TestGenericObjectPool.java
Author: markt
Date: Thu Oct 17 12:50:27 2013
New Revision: 1533064
URL: http://svn.apache.org/r1533064
Log:
Fix some low hanging IDE warnings
Modified:
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestObjectPool.java
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java?rev=1533064&r1=1533063&r2=1533064&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java Thu Oct 17 12:50:27 2013
@@ -29,7 +29,7 @@ import org.junit.After;
import org.junit.Test;
/**
- * Abstract {@link TestCase} for {@link ObjectPool} implementations.
+ * Abstract test case for {@link ObjectPool} implementations.
* @version $Revision$
*/
public abstract class TestKeyedObjectPool {
Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestObjectPool.java?rev=1533064&r1=1533063&r2=1533064&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/TestObjectPool.java Thu Oct 17 12:50:27 2013
@@ -31,7 +31,7 @@ import java.util.Iterator;
import java.util.NoSuchElementException;
/**
- * Abstract {@link TestCase} for {@link ObjectPool} implementations.
+ * Abstract test case for {@link ObjectPool} implementations.
* @version $Revision$
*/
public abstract class TestObjectPool {
Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java?rev=1533064&r1=1533063&r2=1533064&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java Thu Oct 17 12:50:27 2013
@@ -18,6 +18,7 @@
package org.apache.commons.pool2.impl;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertSame;
@@ -400,9 +401,9 @@ public class TestGenericKeyedObjectPool
}
{
pool.setBlockWhenExhausted(true);
- assertEquals(true,pool.getBlockWhenExhausted());
+ assertTrue(pool.getBlockWhenExhausted());
pool.setBlockWhenExhausted(false);
- assertEquals(false,pool.getBlockWhenExhausted());
+ assertFalse(pool.getBlockWhenExhausted());
}
}
Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java?rev=1533064&r1=1533063&r2=1533064&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java Thu Oct 17 12:50:27 2013
@@ -18,6 +18,7 @@
package org.apache.commons.pool2.impl;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
@@ -791,9 +792,9 @@ public class TestGenericObjectPool exten
}
{
pool.setBlockWhenExhausted(true);
- assertEquals(true,pool.getBlockWhenExhausted());
+ assertTrue(pool.getBlockWhenExhausted());
pool.setBlockWhenExhausted(false);
- assertEquals(false,pool.getBlockWhenExhausted());
+ assertFalse(pool.getBlockWhenExhausted());
}
}