You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/01 19:17:43 UTC
[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration
Hello Attila Bukor,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14335
to review the following change.
Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration
......................................................................
TestMiniKuduCluster: deflake testHiveMetastoreIntegration
50 seconds for the entire test isn't enough considering just the HMS itself
is given up to 60s to start (see mini_hms.cc). So let's double it.
Change-Id: I53fb1fa826e3c5c5d9d032fa88bf584300aeedfe
---
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/14335/1
--
To view, visit http://gerrit.cloudera.org:8080/14335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53fb1fa826e3c5c5d9d032fa88bf584300aeedfe
Gerrit-Change-Number: 14335
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14335 )
Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53fb1fa826e3c5c5d9d032fa88bf584300aeedfe
Gerrit-Change-Number: 14335
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:49:41 +0000
Gerrit-HasComments: No
[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14335 )
Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53fb1fa826e3c5c5d9d032fa88bf584300aeedfe
Gerrit-Change-Number: 14335
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:53:49 +0000
Gerrit-HasComments: No
[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14335 )
Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration
......................................................................
TestMiniKuduCluster: deflake testHiveMetastoreIntegration
50 seconds for the entire test isn't enough considering just the HMS itself
is given up to 60s to start (see mini_hms.cc). So let's double it.
Change-Id: I53fb1fa826e3c5c5d9d032fa88bf584300aeedfe
Reviewed-on: http://gerrit.cloudera.org:8080/14335
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I53fb1fa826e3c5c5d9d032fa88bf584300aeedfe
Gerrit-Change-Number: 14335
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)