[GitHub] [hudi] xushiyan commented on a diff in pull request #6548: [HUDI-4749] Fixing full cleaning to leverage metadata table

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #6548:
URL: https://github.com/apache/hudi/pull/6548#discussion_r959904836


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -206,15 +206,7 @@ private List<String> getPartitionPathsForIncrementalCleaning(HoodieCleanMetadata
    */
   private List<String> getPartitionPathsForFullCleaning() {
     // Go to brute force mode of scanning all partitions
-    try {
-      // Because the partition of BaseTableMetadata has been deleted,
-      // all partition information can only be obtained from FileSystemBackedTableMetadata.

Review Comment:
   trying to understand this previous comment, as questioned here https://github.com/apache/hudi/pull/5169/files#r957849431
   
   under what scenario has the metadata table's partition being delete? even deleting synchronously, we should make use of metadata table first then delete metadata and data altogether?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org