You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2008/08/13 07:37:44 UTC
[jira] Created: (BUILDR-130) Allow working with groups in
namespaces
Allow working with groups in namespaces
---------------------------------------
Key: BUILDR-130
URL: https://issues.apache.org/jira/browse/BUILDR-130
Project: Buildr
Issue Type: Improvement
Components: Dependency management
Affects Versions: 1.3.2
Reporter: Ittay Dror
If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Assaf Arkin resolved BUILDR-130.
--------------------------------
Resolution: Won't Fix
Let's reopen when we get a better explanation of the problem + spec to show the expected behavior.
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635693#action_12635693 ]
Ittay Dror commented on BUILDR-130:
-----------------------------------
In the use case I'm describing, #artifact receives a symbol, so it calls artifact_ns.fetch to get the artifact. However, the symbol was created with #group (artifact_ns.foo = group(...)), so an array is returned. Currently #artifact can't handle it because it can't handle arrays. So #group cannot be used to assign a set of artifacts to a symbol. This means loosing some functionality when using artifact namespaces compared to using constant values. (where 'with CONSTANT_CREATED_WITH_GROUP' works fine since it uses #artifacts first)
Forget the patch, I was trying to be helpful, but apparently don't understand the philosophy behind each method. What I'd like is to be able to group several artifacts into a single namespace symbol
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (BUILDR-130) Allow working with groups in namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror closed BUILDR-130.
-----------------------------
Resolution: Invalid
now with the right resolution
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Assignee: Victor Hugo Borja
> Fix For: 1.4
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-130:
---------------------------------
Fix Version/s: (was: 1.3.4)
1.4
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Assignee: Victor Hugo Borja
> Fix For: 1.4
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Assaf Arkin resolved BUILDR-130.
--------------------------------
Resolution: Incomplete
The artifact method is designed to return a single artifact. That it cannot be used in all contexts is acceptable. If this issue is about something other than artifact returning artifact, as the title suggest, please elaborate, otherwise let's move on.
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror updated BUILDR-130:
------------------------------
Attachment: buildr.patch
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Assaf Arkin updated BUILDR-130:
-------------------------------
Fix Version/s: (was: 1.3.4)
Assignee: Victor Hugo Borja
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Assignee: Victor Hugo Borja
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror reopened BUILDR-130:
-------------------------------
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622306#action_12622306 ]
Assaf Arkin commented on BUILDR-130:
------------------------------------
a) need a spec to specify what the new behavior is.
b) artifact method returns a single artifact, so it cannot take array as an argument.
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror updated BUILDR-130:
------------------------------
Fix Version/s: 1.3.3
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635488#action_12635488 ]
Assaf Arkin commented on BUILDR-130:
------------------------------------
Patch is wrong: artifact returns an artifact, so it can never accept an array. I'm also wondering about a spec to show the use case?
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622313#action_12622313 ]
Ittay Dror commented on BUILDR-130:
-----------------------------------
i attached a patch that works for me.
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-130) Allow working with groups in
namespaces
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635480#action_12635480 ]
lacton commented on BUILDR-130:
-------------------------------
I reviewed your patch, but I must admit I do not understand what you are trying to achieve.
Will you give an example of how you use this feature?
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror reopened BUILDR-130:
-------------------------------
reopen to close with proper status. sorry for the noise
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Assignee: Victor Hugo Borja
> Fix For: 1.4
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-130) Allow working with groups in
namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror reopened BUILDR-130:
-------------------------------
the title is about allowing to work with groups in namespaces. nothing about the #artifact method.
the old way allowed
SOME_CONST = group(....)
define 'foo' do
compile.with SOME_CONST
end
but this is not possible when using namespaces:
this does not work:
artifact_ns.some = group(...)
define 'foo' do
compile.with :some
end
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.3
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (BUILDR-130) Allow working with groups in namespaces
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ittay Dror closed BUILDR-130.
-----------------------------
Resolution: Fixed
after reviewing this issue, it looks like ArtifactNamespace#group is the right thing to use.
> Allow working with groups in namespaces
> ---------------------------------------
>
> Key: BUILDR-130
> URL: https://issues.apache.org/jira/browse/BUILDR-130
> Project: Buildr
> Issue Type: Improvement
> Components: Dependency management
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Assignee: Victor Hugo Borja
> Fix For: 1.4
>
> Attachments: buildr.patch
>
>
> If I work with a group in a namespace, then passing the group's name means the artifact method receives an array from ArtifactNamespace#fetch
> Attached is a patch to fix this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.