You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/24 01:47:28 UTC

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3934: [Refactor] Replace some boost to std in OlapScanNode

chaoyli commented on a change in pull request #3934:
URL: https://github.com/apache/incubator-doris/pull/3934#discussion_r444598726



##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -186,9 +185,9 @@ Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eo
 
     // check if Canceled.
     if (state->is_cancelled()) {
-        boost::unique_lock<boost::mutex> l(_row_batches_lock);
+        std::unique_lock<std::mutex> l(_row_batches_lock);

Review comment:
       You can use util/condition_variable.h.
   It comes from kudu, it's use is simple than std::




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org