You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2009/05/21 22:14:26 UTC

svn commit: r777240 - /maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java

Author: bentmann
Date: Thu May 21 20:14:26 2009
New Revision: 777240

URL: http://svn.apache.org/viewvc?rev=777240&view=rev
Log:
o Added note about need to tighten model validator with regard to plugin version

Modified:
    maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java

Modified: maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
URL: http://svn.apache.org/viewvc/maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java?rev=777240&r1=777239&r2=777240&view=diff
==============================================================================
--- maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java (original)
+++ maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java Thu May 21 20:14:26 2009
@@ -163,6 +163,13 @@
                 validateStringNotEmpty( "build.plugins.plugin.artifactId", result, p.getArtifactId() );
 
                 validateStringNotEmpty( "build.plugins.plugin.groupId", result, p.getGroupId() );
+                
+                /*
+                 * FIXME: Enforce the existence of a version, no more guessing but reproducibility. We can't do this
+                 * right now as it would affect dependency resolution via the metadata source. As a prerequisite, we
+                 * need to tell the validator which level of strictness we want or alternatively disable validation
+                 * completely for the metadata source.
+                 */
             }
 
             for ( Iterator it = build.getResources().iterator(); it.hasNext(); )