[GitHub] [druid] kfaraz commented on a diff in pull request #13939: Lower default maxRowsInMemory for realtime ingestion.

["kfaraz (via GitHub)" <gi...@apache.org>]

kfaraz commented on code in PR #13939:
URL: https://github.com/apache/druid/pull/13939#discussion_r1138551175


##########
server/src/main/java/org/apache/druid/segment/indexing/RealtimeTuningConfig.java:
##########
@@ -129,7 +129,7 @@ public RealtimeTuningConfig(
   )
   {
     this.appendableIndexSpec = appendableIndexSpec == null ? DEFAULT_APPENDABLE_INDEX : appendableIndexSpec;
-    this.maxRowsInMemory = maxRowsInMemory == null ? DEFAULT_MAX_ROWS_IN_MEMORY : maxRowsInMemory;
+    this.maxRowsInMemory = maxRowsInMemory == null ? DEFAULT_MAX_ROWS_IN_MEMORY_BATCH : maxRowsInMemory;

Review Comment:
   Probably got missed.
   ```suggestion
       this.maxRowsInMemory = maxRowsInMemory == null ? DEFAULT_MAX_ROWS_IN_MEMORY_REALTIME : maxRowsInMemory;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org