You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/30 19:05:30 UTC
[GitHub] [zookeeper] eolivelli opened a new pull request #1238:
ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 -
part2
eolivelli opened a new pull request #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238
- upgrade to Apache Parent 23
- disable maven remote plugin
- move source assembly execution before sources generation
- move git properties resolution to the correct phase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli closed pull request #1238: ZOOKEEPER-3695:
Source release tarball does not match repository in 3.6.0 - part2
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1238: ZOOKEEPER-3695:
Source release tarball does not match repository in 3.6.0 - part2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580408419
@anmolnar @nkalmar I need a little help merging this patch.
Please cherry pick to branch-3.6 and release-3.6.0
I saw that the source release tarball still does not reflect perfectly the repository
in order to build the tarball the command is:
`mvn clean install -DskipTests -Pfull-build -Papache-release`
a shortcut is to add '-N' (non recursive) in order to build only the top level project
`mvn clean install -DskipTests -Pfull-build -Papache-release -N`
remember to issue a "git clean -xfd" in order to have a clean git repository
I feel that zookeeper-server/src/main/resources/git.properties is in the wrong place, it is a generated resource and it should stay in zookeeper-server/target/generated-resources/git.properties or something like that.
btw This patch does not address this issue, and the package is built correctly only if you start with a clean git repository
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1238: ZOOKEEPER-3695:
Source release tarball does not match repository in 3.6.0 - part2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580690479
PR #1239 has been fixed, now this branch is good for merge.
Let's wait CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli edited a comment on issue #1238:
ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 -
part2
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580758188
Maybe we can just do the change about disabling the remote resources plugin.
Nothing more
Did you have time to test this patch locally? This way we can save time and prevent -1s during the VOTE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1238: ZOOKEEPER-3695:
Source release tarball does not match repository in 3.6.0 - part2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580758188
Maybe we can just do the change about disabling the remote resources plugin.
Nothing more
Did you have time to test this patch locally? This way we can save time in case of -1 during the VOTE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1238: ZOOKEEPER-3695:
Source release tarball does not match repository in 3.6.0 - part2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580408776
current master build is broken.
The patch applies cleanly to branch 3.6 without problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1238: ZOOKEEPER-3695:
Source release tarball does not match repository in 3.6.0 - part2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580689012
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services