[GitHub] [superset] geido commented on a diff in pull request #24205: feat(sqllab): SQLEditor Extension

["geido (via GitHub)" <gi...@apache.org>]

geido commented on code in PR #24205:
URL: https://github.com/apache/superset/pull/24205#discussion_r1213310366


##########
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx:
##########
@@ -673,6 +684,15 @@ const SqlEditor = ({
         onDragEnd={onResizeEnd}
       >
         <div ref={northPaneRef} className="north-pane">
+          {SqlFormExtension && (
+            <SqlFormExtension
+              queryEditorId={queryEditor.id}
+              setQueryEditorAndSaveSqlWithDebounce={

Review Comment:
   @Antonio-RiveroMartnez I am thinking if we need to pass `setQueryEditorAndSaveSqlWithDebounce` and `startQuery` or if those can be implemented by hooking into the state?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org