You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/27 13:47:00 UTC

[jira] [Commented] (DISPATCH-1630) Coverity issues on master branch

    [ https://issues.apache.org/jira/browse/DISPATCH-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093531#comment-17093531 ] 

ASF GitHub Bot commented on DISPATCH-1630:
------------------------------------------

ganeshmurthy opened a new pull request #728:
URL: https://github.com/apache/qpid-dispatch/pull/728


   …ndle are non null. Fix for issue detected by Coverity


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Coverity issues on master branch
> --------------------------------
>
>                 Key: DISPATCH-1630
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1630
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.11.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.12.0
>
>
> {noformat}
> New defect(s) Reported-by: Coverity Scan
> Showing 1 of 1 defect(s)
> ** CID 355485:  Null pointer dereferences  (FORWARD_NULL)
> ________________________________________________________________________________________________________
> *** CID 355485:  Null pointer dereferences  (FORWARD_NULL)
> /home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c: 181 in handle_events()
> 175     static int handle_events(connection_t* c) {
> 176         if (!c->qd_conn) {
> 177             return unexpected_close(c->wsi, "not-established");
> 178         }
> 179         pn_event_t *e;
> 180         while ((e = pn_connection_driver_next_event(&c->driver))) {
> >>>     CID 355485:  Null pointer dereferences  (FORWARD_NULL)
> >>>     Passing null pointer "c->qd_conn" to "qd_connection_handle", which dereferences it.
> 181             if (!qd_connection_handle(c->qd_conn, e)) {
> 182                 c->qd_conn = 0;  // connection closed
> 183             }
> 184         }
> 185         if (pn_connection_driver_write_buffer(&c->driver).size) {
> 186             lws_callback_on_writable(c->wsi);
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org