You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/11/17 03:20:51 UTC
[PR] Add Errata support to YAML configuration support (promoted from IPAllow) [trafficserver]
SolidWallOfCode opened a new pull request, #10809:
URL: https://github.com/apache/trafficserver/pull/10809
Support printing `YAML::Mark` in `Errata` instances, which makes parsing error reporting easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Errata support to YAML configuration support (promoted from IPAllow) [trafficserver]
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode merged PR #10809:
URL: https://github.com/apache/trafficserver/pull/10809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Errata support to YAML configuration support (promoted from IPAllow) [trafficserver]
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on code in PR #10809:
URL: https://github.com/apache/trafficserver/pull/10809#discussion_r1397757981
##########
include/tscpp/util/YamlCfg.h:
##########
@@ -81,3 +82,9 @@ namespace Yaml
} // end namespace Yaml
} // end namespace ts
+
+namespace swoc
+{
+// This needs to be in namespace "swoc" or "YAML" or ADL doesn't find the overload.
+extern BufferWriter &bwformat(BufferWriter &w, bwf::Spec const &spec, YAML::Mark const &mark);
Review Comment:
Habit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Errata support to YAML configuration support (promoted from IPAllow) [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #10809:
URL: https://github.com/apache/trafficserver/pull/10809#discussion_r1397663177
##########
include/tscpp/util/YamlCfg.h:
##########
@@ -81,3 +82,9 @@ namespace Yaml
} // end namespace Yaml
} // end namespace ts
+
+namespace swoc
+{
+// This needs to be in namespace "swoc" or "YAML" or ADL doesn't find the overload.
+extern BufferWriter &bwformat(BufferWriter &w, bwf::Spec const &spec, YAML::Mark const &mark);
Review Comment:
Why `extern`? Won't this have external linkage by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org