You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/25 15:40:05 UTC
[GitHub] [camel] rubenvp8510 opened a new pull request #4684: [WIP] Update to opentelemetry 0.11
rubenvp8510 opened a new pull request #4684:
URL: https://github.com/apache/camel/pull/4684
Signed-off-by: Ruben Vargas <ru...@gmail.com>
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4684: [WIP] Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4684:
URL: https://github.com/apache/camel/pull/4684#discussion_r530474884
##########
File path: components/camel-opentelemetry/pom.xml
##########
@@ -80,7 +75,7 @@
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
- <artifactId>opentelemetry-exporters-inmemory</artifactId>
+ <artifactId>opentelemetry-sdk-testing</artifactId>
Review comment:
Is this a test scope dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rubenvp8510 commented on pull request #4684: [CAMEL-15894] - Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
rubenvp8510 commented on pull request #4684:
URL: https://github.com/apache/camel/pull/4684#issuecomment-734424814
@oscerd I reviewed and sent a PR to karaf repository: https://github.com/apache/camel-karaf/pull/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4684: [CAMEL-15894] - Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4684:
URL: https://github.com/apache/camel/pull/4684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rubenvp8510 commented on a change in pull request #4684: [WIP] Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
rubenvp8510 commented on a change in pull request #4684:
URL: https://github.com/apache/camel/pull/4684#discussion_r530498217
##########
File path: components/camel-opentelemetry/pom.xml
##########
@@ -80,7 +75,7 @@
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
- <artifactId>opentelemetry-exporters-inmemory</artifactId>
+ <artifactId>opentelemetry-sdk-testing</artifactId>
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rubenvp8510 commented on pull request #4684: [WIP] Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
rubenvp8510 commented on pull request #4684:
URL: https://github.com/apache/camel/pull/4684#issuecomment-733811485
Wondering why other modules have style failures, I haven't touched it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4684: [CAMEL-15894] - Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4684:
URL: https://github.com/apache/camel/pull/4684#issuecomment-734085591
@rubenvp8510 the feature related to this component lives here: https://github.com/apache/camel-karaf/blob/master/platforms/karaf/features/src/main/resources/features.xml#L1997
To check you need to fully build the main camel repository and on the camel-karaf repo run mvn clean install in the platforms/karaf/features folder. There will be a verification of the features and you'll eventually get errors.
By the way we can also check it later if you don't have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rubenvp8510 commented on pull request #4684: [CAMEL-15894] - Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
rubenvp8510 commented on pull request #4684:
URL: https://github.com/apache/camel/pull/4684#issuecomment-734031800
@oscerd I'm not familiar with camel-karaf feature. Could you provide me some guiadance on what I need to check?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4684: [WIP] Update to opentelemetry 0.11
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4684:
URL: https://github.com/apache/camel/pull/4684#discussion_r530499296
##########
File path: components/camel-opentelemetry/pom.xml
##########
@@ -80,7 +75,7 @@
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
- <artifactId>opentelemetry-exporters-inmemory</artifactId>
+ <artifactId>opentelemetry-sdk-testing</artifactId>
Review comment:
It makes sense to add scope test then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org