You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yangsen5 (via GitHub)" <gi...@apache.org> on 2024/10/10 09:44:31 UTC

[PR] Ys app [nuttx-apps]

yangsen5 opened a new pull request, #2675:
URL: https://github.com/apache/nuttx-apps/pull/2675

   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Ys app [nuttx-apps]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2675:
URL: https://github.com/apache/nuttx-apps/pull/2675#issuecomment-2404611812

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   I need the content of the PR to determine if it meets the requirements. Please provide the following:
   
   * **The actual PR content:**  This includes the PR description, code changes, and any comments within the PR. 
   * **The link to the PR itself (if available):** This will give me context and access to the full conversation around the PR.
   
   With this information, I can assess if the PR meets the NuttX requirements and provide you with a concise answer. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] nxcode improvement [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2675:
URL: https://github.com/apache/nuttx-apps/pull/2675#discussion_r1795778702


##########
system/nxcodec/nxcodec.c:
##########
@@ -60,20 +60,27 @@ static int nxcodec_prepare_contexts(FAR nxcodec_t *codec)
   ret = ioctl(codec->fd, VIDIOC_QUERYCAP, &cap);
   if (ret < 0)
     {
+      printf("nxcodec VIDIOC_QUERYCAP error: %d\n", errno);

Review Comment:
   command line program use printf, service use syslog which is the nornal POSIX program convention.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] nxcode improvement [nuttx-apps]

Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on code in PR #2675:
URL: https://github.com/apache/nuttx-apps/pull/2675#discussion_r1795707008


##########
system/nxcodec/nxcodec.c:
##########
@@ -60,20 +60,27 @@ static int nxcodec_prepare_contexts(FAR nxcodec_t *codec)
   ret = ioctl(codec->fd, VIDIOC_QUERYCAP, &cap);
   if (ret < 0)
     {
+      printf("nxcodec VIDIOC_QUERYCAP error: %d\n", errno);

Review Comment:
   why printf and not logging? printf cannot be controlled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] nxcode improvement [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2675:
URL: https://github.com/apache/nuttx-apps/pull/2675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] nxcode improvement [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2675:
URL: https://github.com/apache/nuttx-apps/pull/2675#discussion_r1795778702


##########
system/nxcodec/nxcodec.c:
##########
@@ -60,20 +60,27 @@ static int nxcodec_prepare_contexts(FAR nxcodec_t *codec)
   ret = ioctl(codec->fd, VIDIOC_QUERYCAP, &cap);
   if (ret < 0)
     {
+      printf("nxcodec VIDIOC_QUERYCAP error: %d\n", errno);

Review Comment:
   command line program use printf, server use syslog which is the nornal POSIX program convention.



##########
system/nxcodec/nxcodec.c:
##########
@@ -60,20 +60,27 @@ static int nxcodec_prepare_contexts(FAR nxcodec_t *codec)
   ret = ioctl(codec->fd, VIDIOC_QUERYCAP, &cap);
   if (ret < 0)
     {
+      printf("nxcodec VIDIOC_QUERYCAP error: %d\n", errno);

Review Comment:
   command line program use printf, server use syslog which is the normal POSIX program convention.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org